gh-104050: Argument Clinic: Annotate the BufferSeries class#106935
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
_TextAccumulator has no '_text' attribute; it has 'text'
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland changed the title 
serhiy-storchaka approved these changes Jul 21, 2023
Tools/clinic/clinic.py Outdated
Comment on lines 1973 to 1976
| def__getitem__( | ||
| self, | ||
| i: int | ||
| ) ->_TextAccumulator: |
There was a problem hiding this comment.
Why not write it in one line? It is still pretty short.
ContributorAuthor
There was a problem hiding this comment.
Sure; I have not yet developed a preference when it comes to annotation style :)
Member
There was a problem hiding this comment.
FWIW, I agree with Serhiy — I would probably put this all on one line — but I also don't really care much either way (life's too short to spend it arguing over code formatting preferences 😄)
ContributorAuthor
There was a problem hiding this comment.
(life's too short to spend it arguing over code formatting preferences 😄)
No, it isn't! 😆
ContributorAuthor
erlend-aasland commented Jul 21, 2023
On hold until #106972 has landed. |
ContributorAuthor
erlend-aasland commented Jul 22, 2023
Thanks for the reviews! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.