Skip to content

gh-106948: Add standard external names to nitpick_ignore#106949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 11 commits into from
Jul 22, 2023
Merged

gh-106948: Add standard external names to nitpick_ignore #106949

serhiy-storchaka merged 11 commits into from
Jul 22, 2023

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commented Jul 21, 2023•
edited by github-actions bot
Loading

It includes standard C types, macros and variables like "size_t", "LONG_MAX" and "errno", and standard environment variables like "PATH".

📚 Documentation preview 📚: https://cpython-previews--106949.org.readthedocs.build/

@serhiy-storchaka
pythongh-106948: Add standard external names to nitpick_ignore
9079a34
It includes standard C types, macros and variables like "size_t", "LONG_MAX" and "errno", and standard environment variables like "PATH".
@serhiy-storchakaserhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 21, 2023
@bedevere-botbedevere-bot mentioned this pull request Jul 21, 2023
Closed
@serhiy-storchakaserhiy-storchaka marked this pull request as ready for review July 22, 2023 14:32
erlend-aasland
erlend-aasland approved these changes Jul 22, 2023
View reviewed changes
Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Why are you using :c:texpr: for _Bool?

@serhiy-storchaka
Copy link
MemberAuthor

serhiy-storchaka commented Jul 22, 2023

Why are you using :c:texpr: for _Bool?

Because it is the correct role for a type expression in C. I prepared a large patch for using :c:texpr:, but it depends on this PR. And this PR depends on #107011.

@serhiy-storchakaserhiy-storchaka marked this pull request as draft July 22, 2023 16:18
@serhiy-storchakaserhiy-storchaka marked this pull request as ready for review July 22, 2023 17:20
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jul 22, 2023

I thought the T in :texpr: stood for text, not type: https://www.sphinx-doc.org/en/master/usage/restructuredtext/domains.html#inline-expressions-and-types

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jul 22, 2023

Also, _Bool is a built-in C type. I don't see why it should be marked up differently from int.

@serhiy-storchaka
Copy link
MemberAuthor

serhiy-storchaka commented Jul 22, 2023

You are right. I misread the documentation. Thank you, you saved me from opening a new issue.

@serhiy-storchakaserhiy-storchaka merged commit f8b7fe2 into python:mainJul 22, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jul 22, 2023

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchakaserhiy-storchaka deleted the nitpick_ignore branch July 22, 2023 18:35
@miss-islington
Copy link
Contributor

miss-islington commented Jul 22, 2023

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f8b7fe2f2647813ae8249675a80e59c117d30fe1 3.12

@miss-islington
Copy link
Contributor

miss-islington commented Jul 22, 2023

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f8b7fe2f2647813ae8249675a80e59c117d30fe1 3.11

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 22, 2023
@serhiy-storchaka
[3.12]pythongh-106948: Add standard external names to nitpick_ignore (…
adb7c9b
…pythonGH-106949) It includes standard C types, macros and variables like "size_t", "LONG_MAX" and "errno", and standard environment variables like "PATH".. (cherry picked from commit f8b7fe2) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jul 22, 2023

GH-107060 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jul 22, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 22, 2023
@serhiy-storchaka
[3.11]pythongh-106948: Add standard external names to nitpick_ignore (…
2c76f6a
…pythonGH-106949) It includes standard C types, macros and variables like "size_t", "LONG_MAX" and "errno", and standard environment variables like "PATH".. (cherry picked from commit f8b7fe2) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jul 22, 2023

GH-107061 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jul 22, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 22, 2023
@serhiy-storchaka
[3.12]pythongh-106948: Add standard external names to nitpick_ignore (…
95e6108
…pythonGH-106949) It includes standard C types, macros and variables like "size_t", "LONG_MAX" and "errno", and standard environment variables like "PATH". (cherry picked from commit f8b7fe2) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
ambv pushed a commit that referenced this pull request Jul 23, 2023
@serhiy-storchaka
[3.11]gh-106948: Add standard external names to nitpick_ignore (GH-1…
ec8718d
…06949) (#107061) It includes standard C types, macros and variables like "size_t", "LONG_MAX" and "errno", and standard environment variables like "PATH".. (cherry picked from commit f8b7fe2)
ambv pushed a commit that referenced this pull request Jul 23, 2023
@serhiy-storchaka
[3.12]gh-106948: Add standard external names to nitpick_ignore (GH-1…
456cf8b
…06949) (#107060) * [3.12] gh-106948: Add standard external names to nitpick_ignore (GH-106949) It includes standard C types, macros and variables like "size_t", "LONG_MAX" and "errno", and standard environment variables like "PATH". (cherry picked from commit f8b7fe2) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> * Delete 2023-05-31-18-37-57.gh-issue-105156.R4El5V.rst
mementum pushed a commit to mementum/cpython that referenced this pull request Jul 23, 2023
@serhiy-storchaka@mementum
pythongh-106948: Add standard external names to nitpick_ignore (pytho…
28cbc89
…nGH-106949) It includes standard C types, macros and variables like "size_t", "LONG_MAX" and "errno", and standard environment variables like "PATH".
@serhiy-storchakaserhiy-storchaka removed their assignment Jul 25, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka@erlend-aasland@miss-islington@bedevere-bot