gh-106320: Remove _Py_SwappedOp from the C API#107036
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
corona10 approved these changes Jul 22, 2023
Member
corona10 left a comment
corona10 left a comment There was a problem hiding this comment.
lgtm, if someone is using this API, they can write their utility function.
MemberAuthor
vstinner commented Jul 22, 2023
If someone uses it, we can consider exposing a public API for that. Or they can just copy/paste this short array in their code. |
Move _Py_SwappedOp to the internal C API (pycore_object.h). The symbol is still exported since it's part of the stable ABI.
MemberAuthor
vstinner commented Jul 22, 2023
The symbol must still be exported since it's part of the stable ABI. |
mementum pushed a commit to mementum/cpython that referenced this pull request Jul 23, 2023
Move _Py_SwappedOp to the internal C API (pycore_object.h).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move _Py_SwappedOp to the internal C API (pycore_object.h).