gh-107082: Remove debug hack from get_first_executor in test_capi.test_misc#107085
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
vstinner commented Jul 23, 2023
@gvanrossum: If common CI jobs pass, you can try to add the |
gvanrossum added the 🔨 test-with-buildbots 
bedevere-bot commented Jul 23, 2023
🤖 New build scheduled with the buildbot fleet by @gvanrossum for commit 901cf21 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot removed the 🔨 test-with-buildbots 
MemberAuthor
gvanrossum commented Jul 23, 2023
Note: even if this doesn't fix the issue it should still be merged, since that debug |
MemberAuthor
gvanrossum commented Jul 23, 2023
Landing this, even though it doesn't fix the issue (it's still removing debug code that was accidentally committed). |
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 23, 2023
…pi.test_misc (python#107085) (Even though it doesn't look like it fixespythongh-107082 -- see discussion there -- it still removes debug code that should never have been committed.)
mementum pushed a commit to mementum/cpython that referenced this pull request Jul 23, 2023
…pi.test_misc (python#107085) (Even though it doesn't look like it fixespythongh-107082 -- see discussion there -- it still removes debug code that should never have been committed.)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to test this function more thoroughly during debugging I made it call
_testinternalcapi.get_executor()every time, instead of just when aJUMP_BACKWARDopcode is found. This causes it to be called for cache entries, resulting in failing asserts. The fix removes the expression partor 1that I had added.(Is it okay that this function can crash with out of range arguments? Well I suppose it's okay since it's part of
_testinternalcapi.)