gh-62519: Make pgettext search plurals when translation is not found#107118
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ambv reviewed Jul 23, 2023
Misc/NEWS.d/next/Library/2023-07-23-12-26-23.gh-issue-62519.w8-81X.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
ambv added needs backport to 3.11 
Contributor
miss-islington commented Jul 23, 2023
Contributor
miss-islington commented Jul 23, 2023
bedevere-bot commented Jul 23, 2023
GH-107133 is a backport of this pull request to the 3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2023
…found (pythonGH-107118) (cherry picked from commit b3c34e5) Co-authored-by: Tomas R <tomas.roun8@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>
bedevere-bot commented Jul 23, 2023
GH-107134 is a backport of this pull request to the 3.12 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2023
…found (pythonGH-107118) (cherry picked from commit b3c34e5) Co-authored-by: Tomas R <tomas.roun8@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 23, 2023
…found (python#107118) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
mementum pushed a commit to mementum/cpython that referenced this pull request Jul 23, 2023
…found (python#107118) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
carljm added a commit to carljm/cpython that referenced this pull request Jul 24, 2023
* main: (73 commits) Thoroughly refactor the cases generator (python#107151) Docs: Add missing markup to Argument Clinic docs (python#106876) pythongh-107162: Document errcode.h usage in its comment (python#107177) pythongh-106320: Remove private _PyDict C API (python#107145) Fix PyVectorcall_Function doc versionadded (python#107140) Docs: Remove duplicate word in Argument Clinic howto heading (python#107169) pythongh-107017: Change Chapter Strings to Texts in the Introduction chapter. (python#107104) pythongh-106320: Remove private _PyObject C API (python#107159) Docs: fix typo in os.pwrite docstring (python#107087) pythongh-105291: Add link to migration guide for distutils (python#107130) pythongh-106948: Docs: Disable links for C standard library functions, OS utility functions and system calls (python#107062) pythongh-106320: Remove _PyBytes_Join() C API (python#107144) pythongh-106320: Remove private _PyObject C API (python#107147) pythongh-106320: Remove _PyTuple_MaybeUntrack() C API (python#107143) pythongh-106320: Remove _PyIsSelectable_fd() C API (python#107142) Remove superflous whitespaces in `layout.html`. (pythonGH-107067) pythongh-107122: Update what's news for dbm.*dbm.clear() method (pythongh-107135) pythongh-107122: Add clear method to dbm.ndbm module (pythongh-107126) pythongh-62519: Make pgettext search plurals when translation is not found (python#107118) pythongh-107122: Add clear method to dbm.gdbm.module (pythongh-107127) ...
serhiy-storchaka pushed a commit that referenced this pull request Jul 25, 2023
serhiy-storchaka pushed a commit that referenced this pull request Jul 25, 2023
akx pushed a commit to python-babel/babel that referenced this pull request Jul 11, 2024
pgettext can now find the following translation when using `pgettext("ctx", "foo")`: ``` msgctxt "ctx" msgid "foo" msgid_plural "foos" msgstr[0] "foo translated" ``` The upstream CPython PR is python/cpython#107118Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #62519
Now that
gettextis fixed, let's also fixpgettext.