gh-107162: Remove errcode.h header file#107163
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
vstinner commented Jul 23, 2023
cc @pablogsal@lysnikolaou@serhiy-storchaka: see #107162 for the removal rationale. |
Rename Include/errcode.h to Include/internal/pycore_errcode.h.
serhiy-storchaka previously approved these changes Jul 24, 2023
Member
serhiy-storchaka left a comment
serhiy-storchaka left a comment There was a problem hiding this comment.
It is a part of the C API. These codes are returned by PyRun_InteractiveOneFlags(). See Doc/c-api/veryhigh.rst.
MemberAuthor
vstinner commented Jul 24, 2023
So this PR is wrong. I wrote PR #107177 to complete the comment instead. Thanks @serhiy-storchaka for your review! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename Include/errcode.h to Include/internal/pycore_errcode.h.
📚 Documentation preview 📚: https://cpython-previews--107163.org.readthedocs.build/