Skip to content

gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13#107229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 1 commit into from
Jul 25, 2023
Merged

gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13 #107229

serhiy-storchaka merged 1 commit into from
Jul 25, 2023

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commented Jul 25, 2023•
edited by bedevere-bot
Loading

@bedevere-botbedevere-bot mentioned this pull request Jul 21, 2023
Closed
@serhiy-storchakaserhiy-storchakaforce-pushed the limited-capi-PyDict_GetItemRef branch from b0233b5 to 4210c15CompareJuly 25, 2023 10:49
vstinner
vstinner reviewed Jul 25, 2023
View reviewed changes
@vstinner
Copy link
Member

vstinner commented Jul 25, 2023

Oh sorry, I always forget to pay attention to versionning when adding a function to the limited C API.

@serhiy-storchakaserhiy-storchaka changed the title gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13gh-106004: PyDict_GetItemRef() should only be in the limited API 3.10Jul 25, 2023
@serhiy-storchakaserhiy-storchaka changed the title gh-106004: PyDict_GetItemRef() should only be in the limited API 3.10gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13Jul 25, 2023
@serhiy-storchakaserhiy-storchakaforce-pushed the limited-capi-PyDict_GetItemRef branch from 4210c15 to 6730eecCompareJuly 25, 2023 11:07
vstinner
vstinner approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@serhiy-storchakaserhiy-storchaka merged commit 2b1a81e into python:mainJul 25, 2023
@serhiy-storchakaserhiy-storchaka deleted the limited-capi-PyDict_GetItemRef branch July 25, 2023 18:48
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
@serhiy-storchaka@jtcave
pythongh-106004: PyDict_GetItemRef() should only be in the limited AP…
af34f7d
…I 3.13 (pythonGH-107229)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

skip newstopic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka@vstinner@bedevere-bot