Skip to content

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygoodAlexWaygood commented Jul 26, 2023

In several cases, this allows us to use simpler type annotations, making the code easier for both type checkers and humans to understand. It also allows us to get rid of a few assertions that were introduced into the code base for purposes of type narrowing, but are now no longer necessary.

@bedevere-botbedevere-bot mentioned this pull request Jul 26, 2023
7 tasks
@AlexWaygoodAlexWaygood changed the title gh-104683: Make most arguments to Class and Function requiredgh-104683: Argument Clinic: Make most arguments to Class and Function requiredJul 26, 2023
Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice; thanks!

@AlexWaygoodAlexWaygood merged commit 14d074e into python:mainJul 26, 2023
@AlexWaygoodAlexWaygood deleted the clinic-function-simplify branch July 26, 2023 13:28
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexWaygood@erlend-aasland@bedevere-bot