gh-107424: avoid using lambda functions in textwrap.indent()#107426
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned by #107374 (comment), avoiding the use of a lambda function when no predicate is specified is expected to improve the performances.
The benchmarks reported on the issue corroborate this assumption. However, I would like to know if this is only because my laptop is dying (caching
.appendcalls do not seem to help however).I am waiting for changes to be verified before creating a NEWS entry (should I create it in conjunction to the already created one by @methane ?)
textwrap.indenta bit more. #107424