Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-106078: Suppress the warning caused by multi-phase initialization of decimal#107524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-106078: Suppress the warning caused by multi-phase initialization of decimal#107524
Uh oh!
There was an error while loading. Please reload this page.
Conversation
CharlieZhao95 commented Aug 1, 2023 • edited by bedevere-bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-bot
Uh oh!
There was an error while loading. Please reload this page.
CharlieZhao95 commented Aug 1, 2023
Maybe we can skip news for this PR. |
CharlieZhao95 commented Aug 1, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
It looks like the global variable check is failing, the tool cannot ignore static variables inside functions. |
Uh oh!
There was an error while loading. Please reload this page.
Eclips4 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it locally, and it works. Multiple imports of decimal doesn't make any warnings anymore.
LGTM.
AlexWaygood commented Oct 3, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
The warning that's being suppressed here was recently brought up again in #110266 |
erlend-aasland commented Oct 3, 2023
See also the discussion about a global init/exit API for extension modules. |
bedevere-bot commented Oct 7, 2023
|
This warnning is caused by the multi-phase initialization of
decimalmodule. Whendecimalmodule is repeatedly imported,decimal_execwill be executed multiple times and this warning will be raised.See #107287 (comment) for details.
_decimalextension module #106078