Skip to content

gh-104146: Remove dead code from Argument Clinic#107555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 2 commits into from
Aug 2, 2023
Merged

gh-104146: Remove dead code from Argument Clinic #107555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c3e9fa
gh-104146: Remove dead code from Argument Clinic
erlend-aasland Aug 2, 2023
3e200bb
Remove unused import from cpp
erlend-aasland Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1098,7 +1098,6 @@ def parser_body(

parsearg = p.converter.parse_arg(argname, displayname)
if parsearg is None:
#print('Cannot convert %s %r for %s' % (p.converter.__class__.__name__, p.converter.format_unit, p.converter.name), file=sys.stderr)
parser_code = None
break
if has_optional or p.is_optional():
Expand DownExpand Up@@ -1191,7 +1190,6 @@ def parser_body(
displayname = p.get_displayname(i+1)
parsearg = p.converter.parse_arg(argname_fmt % i, displayname)
if parsearg is None:
#print('Cannot convert %s %r for %s' % (p.converter.__class__.__name__, p.converter.format_unit, p.converter.name), file=sys.stderr)
parser_code = None
break
if add_label and (i == pos_only or i == max_pos):
Expand DownExpand Up@@ -4645,13 +4643,11 @@ def next(
state: StateKeeper,
line: str | None = None
) -> None:
# real_print(self.state.__name__, "->", state.__name__, ", line=", line)
self.state = state
if line is not None:
self.state(line)

def state_dsl_start(self, line: str) -> None:
# self.block = self.ClinicOutputBlock(self)
if not self.valid_line(line):
return

Expand Down
1 change: 0 additions & 1 deletion Tools/clinic/cpp.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import dataclasses as dc
import re
import sys
from collections.abc import Callable
from typing import NoReturn


Expand Down