GH-84436: Skip refcounting for known immortals#107605
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
brandtbucher added performance brandtbucher requested review from 1st1, asvetlov, gvanrossum, kumaraditya303, markshannon and willingc as code ownersbrandtbucher added 🔨 test-with-buildbots 
bedevere-bot commented Aug 3, 2023
🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit 8abbc6a 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot commented Aug 3, 2023
🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit 8abbc6a 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot removed 🔨 test-with-buildbots 
gvanrossum approved these changes Aug 3, 2023
Member
gvanrossum left a comment
gvanrossum left a comment There was a problem hiding this comment.
Good change! I'm impressed you found these.
kumaraditya303 approved these changes Aug 4, 2023
MemberAuthor
brandtbucher commented Aug 4, 2023
Checked all 17(!) of the failing buildbots, and they're failing for the same reasons on other PRs. So, unrelated to this change. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are a few dozen places where we're still attempting to increment the refcounts of known immortal objects.