gh-104146: Argument clinic: remove unused methods and variables#107608
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
erlend-aasland approved these changes Aug 3, 2023
Contributor
erlend-aasland left a comment
erlend-aasland left a comment There was a problem hiding this comment.
Looks good to me. make clinic also does not complain.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ivariable inversion_comparitorwas unused (it was a useless use ofenumerate; we can just iterate directly over the iterator).IndentStack.indent(),DSLParser.calculate_indent(),cpp.Monitor.close()andcpp.Monitor.write()all have no test coverage. They are not used or referenced anywhere inTools/clinic; the test suite passes without them; mypy and pyflakes pass without them; and Python builds without them. I think they can all be removed.