Skip to content

gh-104146: Argument clinic: Remove dead code flagged by mypy's truthy-bool check#107627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexWaygood merged 1 commit into from
Aug 4, 2023
Merged

gh-104146: Argument clinic: Remove dead code flagged by mypy's truthy-bool check #107627

AlexWaygood merged 1 commit into from
Aug 4, 2023

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygoodAlexWaygood commented Aug 4, 2023•
edited by bedevere-bot
Loading

And enable that check in our mypy config.

@bedevere-botbedevere-bot mentioned this pull request Aug 4, 2023
Closed
AlexWaygood
AlexWaygood commented Aug 4, 2023
View reviewed changes
AlexWaygood
AlexWaygood commented Aug 4, 2023
View reviewed changes
@AlexWaygoodAlexWaygood mentioned this pull request Aug 4, 2023
Closed
erlend-aasland
erlend-aasland approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@AlexWaygoodAlexWaygood enabled auto-merge (squash) August 4, 2023 13:19
@AlexWaygoodAlexWaygood merged commit 7eba274 into python:mainAug 4, 2023
@AlexWaygoodAlexWaygood deleted the truthy-bool branch August 4, 2023 13:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexWaygood@erlend-aasland@bedevere-bot