GH-106684: raise ResourceWarning when StreamWriter is not closed#107650
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
kumaraditya303 commented Aug 5, 2023
Memray flamegraphs of code on issue. Before: |
kumaraditya303 added type-bug 
kumaraditya303 requested review from 1st1, asvetlov, gvanrossum and willingc as code owners
asvetlov approved these changes Aug 5, 2023
Contributor
miss-islington commented Aug 5, 2023
Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
bedevere-bot commented Aug 5, 2023
GH-107656 is a backport of this pull request to the 3.12 branch. |
bedevere-bot commented Aug 5, 2023
GH-107657 is a backport of this pull request to the 3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 5, 2023
…is not closed (pythonGH-107650) (cherry picked from commit 41178e4) Co-authored-by: Kumar Aditya <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 5, 2023
…is not closed (pythonGH-107650) (cherry picked from commit 41178e4) Co-authored-by: Kumar Aditya <[email protected]>
evildmp pushed a commit to evildmp/cpython that referenced this pull request Aug 5, 2023
bedevere-bot commented Aug 10, 2023
GH-107656 is a backport of this pull request to the 3.12 branch. |
Yhg1s pushed a commit that referenced this pull request Aug 10, 2023
…iter` is not closed by application (GH-107650) (#107656) GH-106684: raise `ResourceWarning` when `asyncio.StreamWriter` is not closed (GH-107650) (cherry picked from commit 41178e4) Co-authored-by: Kumar Aditya <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
miss-islington added a commit to miss-islington/cpython that referenced this pull request Aug 10, 2023
…reamWriter` is not closed by application (pythonGH-107650) (pythonGH-107656) pythonGH-106684: raise `ResourceWarning` when `asyncio.StreamWriter` is not closed (pythonGH-107650) (cherry picked from commit 41178e4) (cherry picked from commit 7853c76) Co-authored-by: Miss Islington (bot) <[email protected]> Co-authored-by: Kumar Aditya <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
kumaraditya303 added a commit that referenced this pull request Aug 10, 2023
…treamWriter` is not closed by application (GH-107650) (GH-107656) (#107836) [3.12] GH-106684: Close `asyncio.StreamWriter` when `asyncio.StreamWriter` is not closed by application (GH-107650) (GH-107656) GH-106684: raise `ResourceWarning` when `asyncio.StreamWriter` is not closed (GH-107650) (cherry picked from commit 41178e4) (cherry picked from commit 7853c76) Co-authored-by: Kumar Aditya <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.