Skip to content

Conversation

@AA-Turner
Copy link
Member

@AA-TurnerAA-Turner commented Aug 6, 2023

I noticed whilst working on #19470 that pyspecific still uses .warn() methods.

A


📚 Documentation preview 📚: https://cpython-previews--107694.org.readthedocs.build/

@AA-TurnerAA-Turner added docs Documentation in the Doc dir skip issue skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 6, 2023
@AA-TurnerAA-Turner requested a review from hugovkAugust 6, 2023 13:48
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

@AA-Turner
Copy link
MemberAuthor

Thanks Alex!

A

@AlexWaygoodAlexWaygood merged commit 9564e31 into python:mainAug 6, 2023
@miss-islington
Copy link
Contributor

Thanks @AA-Turner for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-107695 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Aug 6, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2023
@bedevere-bot
Copy link

GH-107696 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Aug 6, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2023
AlexWaygood pushed a commit that referenced this pull request Aug 6, 2023
…) (#107696) Do not use deprecated ``logger.warn()`` in pyspecific (GH-107694) (cherry picked from commit 9564e31) Co-authored-by: Adam Turner <[email protected]>
Yhg1s pushed a commit that referenced this pull request Aug 6, 2023
…) (#107695) Do not use deprecated ``logger.warn()`` in pyspecific (GH-107694) (cherry picked from commit 9564e31) Co-authored-by: Adam Turner <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@AA-Turner@miss-islington@bedevere-bot@AlexWaygood