Skip to content

gh-107880: Teach Argument Clinic to clone __init__ and __new__ methods#107885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erlend-aasland merged 4 commits into from
Aug 13, 2023
Merged

gh-107880: Teach Argument Clinic to clone __init__ and __new__ methods #107885

erlend-aasland merged 4 commits into from
Aug 13, 2023

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented Aug 11, 2023•
edited by bedevere-bot
Loading

@erlend-aaslanderlend-aasland changed the title WIPgh-107880: Teach Argument Clinic to clone __init__ and __new__ methodsAug 11, 2023
@bedevere-botbedevere-bot mentioned this pull request Aug 11, 2023
Closed
@erlend-aasland

This comment was marked as outdated.

Sign in to view
@erlend-aaslanderlend-aasland marked this pull request as ready for review August 13, 2023 09:13
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Aug 13, 2023

We should also check that it's possible to clone T1.__init__ = T2.__init__ (ditto for __new__), and also T1.meth = T2.__init__.

AlexWaygood
AlexWaygood approved these changes Aug 13, 2023
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erlend-aaslanderlend-aasland merged commit 9b75ada into python:mainAug 13, 2023
@erlend-aaslanderlend-aasland deleted the clinic/clone-init branch August 13, 2023 10:13
This was referenced Aug 15, 2023
Merged
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Aug 15, 2023
@erlend-aasland
pythongh-107880: Argument Clinic: Fix regression inpythongh-107885
0e2e461
pythongh-107885 taught Argument Clinic to clone to __init__ and __new__ methods, but it did not validate the requirements of those special methods.
erlend-aasland added a commit that referenced this pull request Aug 15, 2023
@erlend-aasland@AlexWaygood
gh-107880: Argument Clinic: Fix regression ingh-107885(#107974)
e90036c
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 16, 2023
@erlend-aasland@AlexWaygood@iritkatriel
pythongh-107880: Argument Clinic: Fix regression inpythongh-107885(p…
f336762
…ython#107974) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erlend-aasland@AlexWaygood@bedevere-bot