Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-107801: Improve the accuracy of io.TextIOWrapper.seek docs#107933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-107801: Improve the accuracy of io.TextIOWrapper.seek docs #107933
Uh oh!
There was an error while loading. Please reload this page.
Conversation
erlend-aasland commented Aug 14, 2023 • edited by github-actions bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by github-actions bot
Uh oh!
There was an error while loading. Please reload this page.
Clearly document the supported seek() operations: - Rewind to the start of the stream - Restore a previous strema position (given by tell()) - Fast-forward to the end of the stream
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
AA-Turner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this presentational approach, I think it's a significant improvement over the status quo!
A
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland commented Aug 14, 2023
Thanks for the reviews, Antoine and Adam; highly appreciated. I think we're almost there, but I don't like the repetition in the summary sentence. I thought of changing it to "Set and return ...", but perhaps that is not accurate enough. |
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland commented Aug 19, 2023
It seems the review comments of @pitrou have been addressed. I'll land this next week. |
miss-islington commented Aug 22, 2023
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington commented Aug 22, 2023
Sorry, @erlend-aasland, I could not cleanly backport this to |
miss-islington commented Aug 22, 2023
Sorry, @erlend-aasland, I could not cleanly backport this to |
erlend-aasland commented Aug 22, 2023
I will create a follow-up PR for documenting |
bedevere-bot commented Aug 22, 2023
GH-108262 is a backport of this pull request to the 3.12 branch. |
… docs (python#107933) (cherry picked from commit 7f87ebb) Clearly document the supported seek() operations: - Rewind to the start of the stream - Restore a previous stream position (given by tell()) - Fast-forward to the end of the stream
… docs (python#107933) (cherry picked from commit 7f87ebb) Clearly document the supported seek() operations: - Rewind to the start of the stream - Restore a previous stream position (given by tell()) - Fast-forward to the end of the stream
bedevere-bot commented Aug 22, 2023
GH-108264 is a backport of this pull request to the 3.11 branch. |
Clearly document the supported seek() operations:
📚 Documentation preview 📚: https://cpython-previews--107933.org.readthedocs.build/