Skip to content

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Aug 22, 2023

  • Move test_cppext to its own directory
  • Rename setup_testcppext.py to setup.py
  • Rename _testcppext.cpp to extension.cpp
  • The source (extension.cpp) is now also copied by the test.

* Move test_cppext to its own directory * Rename setup_testcppext.py to setup.py * Rename _testcppext.cpp to extension.cpp * The source (extension.cpp) is now also copied by the test.
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 21dda09600848ac280481f7c64f8d9516dc69bb2 3.11

@bedevere-bot
Copy link

GH-108328 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2023
…8325) * Move test_cppext to its own directory * Rename setup_testcppext.py to setup.py * Rename _testcppext.cpp to extension.cpp * The source (extension.cpp) is now also copied by the test. (cherry picked from commit 21dda09) Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Aug 22, 2023
vstinner added a commit to vstinner/cpython that referenced this pull request Aug 22, 2023
* Move test_cppext to its own directory * Rename setup_testcppext.py to setup.py * Rename _testcppext.cpp to extension.cpp * The source (extension.cpp) is now also copied by the test. (cherry picked from commit 21dda09)
@bedevere-bot
Copy link

GH-108336 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Aug 22, 2023
@vstinnervstinner deleted the test_cppext branch August 22, 2023 19:04
Yhg1s pushed a commit that referenced this pull request Aug 22, 2023
…#108328) gh-108303: Add Lib/test/test_cppext/ sub-directory (GH-108325) * Move test_cppext to its own directory * Rename setup_testcppext.py to setup.py * Rename _testcppext.cpp to extension.cpp * The source (extension.cpp) is now also copied by the test. (cherry picked from commit 21dda09) Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Aug 23, 2023
…108336) gh-108303: Add Lib/test/test_cppext/ sub-directory (#108325) * Move test_cppext to its own directory * Rename setup_testcppext.py to setup.py * Rename _testcppext.cpp to extension.cpp * The source (extension.cpp) is now also copied by the test. (cherry picked from commit 21dda09)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@miss-islington@bedevere-bot