Skip to content

gh-108308: Replace _PyDict_GetItemStringWithError()#108372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Aug 23, 2023
Merged

gh-108308: Replace _PyDict_GetItemStringWithError() #108372

vstinner merged 1 commit into from
Aug 23, 2023

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Aug 23, 2023•
edited by bedevere-bot
Loading

Replace _PyDict_GetItemStringWithError() calls with PyDict_GetItemStringRef() which returns a strong reference to the item.

@bedevere-botbedevere-bot mentioned this pull request Aug 23, 2023
Closed
2 tasks
serhiy-storchaka
serhiy-storchaka reviewed Aug 23, 2023
View reviewed changes
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change!

@vstinner@serhiy-storchaka
pythongh-108308: Replace _PyDict_GetItemStringWithError()
a1192ad
Replace _PyDict_GetItemStringWithError() calls with PyDict_GetItemStringRef() which returns a strong reference to the item. Co-Authored-by: Serhiy Storchaka <storchaka@gmail.com>
@vstinner
Copy link
MemberAuthor

vstinner commented Aug 23, 2023

@serhiy-storchaka: I integrated your suggested changes and made you as a co-author. I addressed your review. Would you mind to review the updated PR?

@vstinnervstinner merged commit 4dc9f48 into python:mainAug 23, 2023
@vstinnervstinner deleted the dict_getref2 branch August 23, 2023 20:59
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Aug 23, 2023

@serhiy-storchaka: I integrated your suggested changes and made you as a co-author.

Oh, it was minor comment. I like how this API allows to write the code in multiple ways, to better fit in every particular case.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@serhiy-storchaka@bedevere-bot