Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islingtonmiss-islington commented Aug 24, 2023

The decorator now requires to be called with parenthesis:

@support.requires_legacy_unicode_capi() 

instead of:

@support.requires_legacy_unicode_capi 

The implementation now only imports _testcapi when the decorator is
called, so "import test.support" no longer imports the _testcapi
extension.
(cherry picked from commit 995f4c4)

Co-authored-by: Victor Stinner vstinner@python.org

…GH-108438) The decorator now requires to be called with parenthesis: @support.requires_legacy_unicode_capi() instead of: @support.requires_legacy_unicode_capi The implementation now only imports _testcapi when the decorator is called, so "import test.support" no longer imports the _testcapi extension. (cherry picked from commit 995f4c4) Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot

@rhettingerrhettinger removed their request for review August 25, 2023 04:48
@Yhg1sYhg1s merged commit 0eb6d87 into python:3.12Aug 25, 2023
@miss-islingtonmiss-islington deleted the backport-995f4c4-3.12 branch August 25, 2023 16:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington@vstinner@Yhg1s@bedevere-bot