Skip to content

Conversation

@corona10
Copy link
Member

@corona10corona10 commented Aug 25, 2023

@corona10
Copy link
MemberAuthor

(.oss) ➜ cpython git:(gh-107265-_PyCode_Quicken-revert) ✗ ./python.exe -Xuops -m test test_sys Raised RLIMIT_NOFILE: 256 -> 1024 0:00:00 load avg: 7.68 Run tests sequentially 0:00:00 load avg: 7.68 [1/1] test_sys Assertion failed: (opcode != ENTER_EXECUTOR), function _PyCode_Quicken, file specialize.c, line 304. Fatal Python error: Aborted Current thread 0x0000000104dbc580 (most recent call first): <no Python frame> Extension modules: _xxsubinterpreters, _xxinterpchannels, _testinternalcapi (total: 3) [1] 20667 abort ./python.exe -Xuops -m test test_sys 

@gvanrossumgvanrossum enabled auto-merge (squash) August 25, 2023 14:58
@gvanrossumgvanrossum merged commit 66b4d9c into python:mainAug 25, 2023
@corona10corona10 deleted the gh-107265-_PyCode_Quicken-revert branch August 25, 2023 15:24
@corona10
Copy link
MemberAuthor

@gvanrossum
Even if we revert this assertion, I still think that decoding instruction to JUMP_BACKWARD is not needed since it's only counter-initialization.

instructions[i+1].cache=adaptive_counter_warmup();

staticinlineuint16_t
adaptive_counter_bits(intvalue, intbackoff){
return (value << ADAPTIVE_BACKOFF_BITS) |
(backoff& ((1<<ADAPTIVE_BACKOFF_BITS)-1));
}

We are in the same line, or do you have different ideas?

@gvanrossum
Copy link
Member

See #108488

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@corona10@gvanrossum@bedevere-bot