Skip to content

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Aug 28, 2023

Add _testclinic_limited project to the Visual Studio solution:

  • In PCbuild/, copy _asyncio.vcxproj to _testclinic_limited.vcxproj,
    replace RootNamespace with "_testclinic_limited".
  • In Visual Stuido, open PCbuild\pcbuild.sln, add the existing
    "_testclinic_limited" project to the solution.
  • Add a dependency from "python" project to "_testclinic_limited"
    project.
  • Save and exit VS.
  • Add "_testclinic_limited" to
    in PCbuild\pcbuild.proj.

@vstinnervstinnerforce-pushed the ac_build_test_limited_win branch from 46c8d54 to 4c79ccbCompareAugust 28, 2023 23:20
@vstinnervstinner changed the title gh-108494: AC: Build _testclinic_limited on Windowsgh-108494: Build _testclinic_limited on WindowsAug 28, 2023
@vstinnervstinner marked this pull request as ready for review August 28, 2023 23:21
@vstinnervstinner requested a review from a team as a code ownerAugust 28, 2023 23:21
Add _testclinic_limited project to the Visual Studio solution: * In PCbuild/, copy _asyncio.vcxproj to _testclinic_limited.vcxproj, replace RootNamespace with "_testclinic_limited". * In Visual Stuido, open PCbuild\pcbuild.sln, add the existing "_testclinic_limited" project to the solution. * Add a dependency from "python" project to "_testclinic_limited" project. * Save and exit VS. * Add "_testclinic_limited" to <TestModules Include="..."> in PCbuild\pcbuild.proj.
@vstinnervstinnerforce-pushed the ac_build_test_limited_win branch from 4c79ccb to 07d21ecCompareAugust 28, 2023 23:26
@vstinner
Copy link
MemberAuthor

The _testclinic_limited is now build as expected on Windows. Logs of the Windows x64 GHA CI:

 _testclinic_limited.c Creating library D:\a\cpython\cpython\PCbuild\amd64\_testclinic_limited_d.lib and object D:\a\cpython\cpython\PCbuild\amd64\_testclinic_limited_d.exp _testclinic_limited.vcxproj -> D:\a\cpython\cpython\PCbuild\amd64\_testclinic_limited_d.pyd 

@vstinnervstinner enabled auto-merge (squash) August 28, 2023 23:33
@vstinnervstinner merged commit 5c68cba into python:mainAug 28, 2023
@vstinnervstinner deleted the ac_build_test_limited_win branch August 28, 2023 23:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner@bedevere-bot