GH-108614: Remove non-debug uses of #if TIER_ONE and #if TIER_TWO from _POP_FRAME op.#108685
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
markshannon commented Aug 30, 2023
I don't think this is newsworthy |
Member
gvanrossum commented Aug 30, 2023
Please give me some time to review this. |
gvanrossum approved these changes Aug 30, 2023
Member
gvanrossum left a comment
gvanrossum left a comment There was a problem hiding this comment.
I'm guessing STORE_IP() is meant to be used by _PUSH_FRAME and you're leaving that for a follow-up PR?
Python/ceval_macros.h Outdated
Comment on lines 384 to 385
| #define STORE_IP() \ | ||
| do{frame->prev_instr = next_instr-1} while (0) |
Member
There was a problem hiding this comment.
I cannot find any place that uses STORE_IP()?
MemberAuthor
There was a problem hiding this comment.
I added all four, then used them where necessary.
I'll remove STORE_IP for now, but we will need it for YIELD_VALUE.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TIER_ONEandTIER_TWOfrom bytecodes.c #108614