GH-108614: Remove TIER_ONE and TIER_TWO from _PUSH_FRAME#108725
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gvanrossum approved these changes Aug 31, 2023
Member
gvanrossum left a comment
gvanrossum left a comment There was a problem hiding this comment.
LGTM. I like how you managed to remove the HAS_ERROR flag from three uops!
Member
gvanrossum commented Sep 1, 2023
Running the tests while forcing -Xuops shows a leak: https://github.com/python/cpython/actions/runs/6042493339/job/16397717979?pr=107820 Though this might be due to another recent PR too. |
MemberAuthor
markshannon commented Sep 1, 2023
Have you tested for leaks on main? |
markshannon changed the title TIER_ONE and TIER_TWO from _PUSH_FRAME``TIER_ONE and TIER_TWO from _PUSH_FRAMEMember
gvanrossum commented Sep 1, 2023
Good call, it looks on main too with -Xuops. So go ahead and merge. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not newsworthy
TIER_ONEandTIER_TWOfrom bytecodes.c #108614