Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-109109: Expose retrieving certificate chains in SSL module#109113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
matiuszka commented Sep 7, 2023 • edited by bedevere-bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-bot
Uh oh!
There was an error while loading. Please reload this page.
ghost commented Sep 7, 2023 • edited by ghost
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by ghost
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Sep 7, 2023
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
bedevere-bot commented Sep 7, 2023
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Sep 7, 2023
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
bedevere-bot commented Sep 8, 2023
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
bedevere-bot commented Sep 8, 2023
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
matiuszka commented Sep 8, 2023
I have made the requested changes; please review again |
bedevere-bot commented Sep 8, 2023
Thanks for making the requested changes! @gpshead: please review the changes made to this pull request. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Sep 8, 2023
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Uh oh!
There was an error while loading. Please reload this page.
gpshead commented Sep 13, 2023
overall the code for this is in good shape, I'm down to picking on the documentation now. :) Don't worry about the NEWS entry that our bot is pinging about, I'll add an appropriate one before merging. |
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
bedevere-bot commented Sep 20, 2023
|
bedevere-bot commented Sep 20, 2023
|
bedevere-bot commented Sep 20, 2023
|
bedevere-bot commented Sep 20, 2023
|
…ython#109113) Adds APIs to get the TLS certificate chains, verified or full unverified, from SSLSocket and SSLObject. Co-authored-by: Gregory P. Smith [Google LLC] <greg@krypto.org>
…ython#109113) Adds APIs to get the TLS certificate chains, verified or full unverified, from SSLSocket and SSLObject. Co-authored-by: Gregory P. Smith [Google LLC] <greg@krypto.org>
This is fix for: #109109
Thanks to that we have documented and exposed Python API for retrieving certificate chains that are mandatory to perform OCSP revocation checks.
📚 Documentation preview 📚: https://cpython-previews--109113.org.readthedocs.build/
ssl.SSLObjectandssl.SSLSocketshould expose method to get certificate chain #109109