Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-109151: Enable readline in the sqlite3 CLI#109152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-109151: Enable readline in the sqlite3 CLI #109152
Conversation
erlend-aasland commented Sep 8, 2023
Thanks, Serhiy, this is very nice! Ideally, we should have this for 3.12. What do you think? I'm not sure it can be considered a defect/bug. |
serhiy-storchaka commented Sep 8, 2023
It is clearly not a bug fix. But it is so much must have feature, that it should go in 3.12.1. Let wait on the release of 3.12.0. |
vstinner commented Sep 15, 2023
This is a new feature, IMO it's too late for Python 3.12. I dislike when Python behavior changes in 3.x.y bug releases, sorry. If you want readline in Python 3.12, you can write your CLI code: #import readlineimportsqlite3.__main__importsyssqlite3.__main__.main(sys.argv[1:]) |
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some remarks on the NEWS entry.
Misc/NEWS.d/next/Library/2023-09-08-19-44-01.gh-issue-109151.GkzkQu.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
…kzkQu.rst Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner commented Sep 15, 2023
I forgot or didn't know that sqlite3 has a command-line interface. I created issue #109435 to document all stdlib modules which provides a command-line interface (CLI). |
serhiy-storchaka commented Sep 15, 2023
The sqlite3 CLI is new in 3.12. This is why I think it is a good idea to backport this change. I always use utilites that read from the stdin with an external wrapper ( |
vstinner commented Sep 15, 2023
Aha, you can negociate with @Yhg1s. First land it in the main branch :-) |
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
miss-islington commented Oct 4, 2023
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
(cherry picked from commit 254e30c) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-110352 is a backport of this pull request to the 3.12 branch. |
erlend-aasland commented Oct 4, 2023
Thanks, Serhiy! |
Uh oh!
There was an error while loading. Please reload this page.