gh-109156: Add tests for de-instrumenting instructions with instrumented lines#109157
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gaogaotiantian changed the title 
Member
markshannon commented Sep 11, 2023
I believe #109131 also fixes this, but will double check once that PR is merged. The fix is here: https://github.com/python/cpython/pull/109131/files#diff-adaefb7da847260ef7aff6e66007bc83f5b226c5389a23e1c9ea622c3b02c419R636 |
gaogaotiantianforce-pushed the monitoring-deinstrument-instruction branch from c9cce8a to e4276a4Comparegaogaotiantian changed the title MemberAuthor
gaogaotiantian commented Sep 12, 2023
Okay @markshannon only the test was left in the PR and it passes with main. |
Member
markshannon commented Sep 13, 2023
Thanks |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat
INSTRUMENTED_LINEspecially inde_instrument_per_instruction. We should keepINSTRUMENTED_LINE.There are some common code, but they are in the middle of the process. So to make it clear, I just basically separated two cases. I did not put as many checks in
INSTRUMENTED_LINEcase as the original code. I can do that if that's desired.