Skip to content

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Sep 11, 2023

@vstinnervstinner merged commit 3b2ecbc into python:mainSep 11, 2023
@vstinnervstinner deleted the resume_check_importlib_magic branch September 11, 2023 07:34
@bedevere-bot
Copy link

There's a new commit after the PR has been approved.

@iritkatriel: please review the changes made to this pull request.

@vstinner
Copy link
MemberAuthor

Thanks for the review @iritkatriel.

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit 3b2ecbc.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/5597) and take a look at the build logs.
  4. Check if the failure is related to this commit (3b2ecbc) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/5597

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "<frozen importlib._bootstrap>", line 1354, in _find_and_load File "<frozen importlib._bootstrap>", line 1325, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 929, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 1001, in exec_module File "<frozen importlib._bootstrap_external>", line 1097, in get_code File "<frozen importlib._bootstrap_external>", line 1196, in get_dataTypeError: descriptor 'close' for '_io.BufferedReader' objects doesn't apply to a '_io.FileIO' object Traceback (most recent call last): File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 1059, in _bootstrap_innerself.run() File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 996, in runself._target(*self._args, **self._kwargs) File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_interpreters.py", line 483, in task interp = interpreters.create() ^^^^^^^^^^^^^^^^^^^^^ File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/interpreters.py", line 25, in createid= _interpreters.create(isolated=isolated) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^RuntimeError: interpreter creation failed k 

@markshannon
Copy link
Member

Thanks @vstinner

@vstinner
Copy link
MemberAuthor

It's unfortunate that we have to increase this number during development even before the first alpha version, but well, as shown in the issue, practicability beats purity here 😁 Apparently people still like PYC during alpha releases 😁

Or maybe we could not write PYC nor use them before first beta version? I don't know. For now, the status quo is to update the MAGIC number.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner@bedevere-bot@markshannon@iritkatriel