gh-109295: Clean up multiprocessing in test_asyncio and test_compileall#109298
Uh oh!
There was an error while loading. Please reload this page.
Conversation
test_asyncio and test_compileall now clean up multiprocessing by calling multiprocessing _cleanup_tests(): explicitly clean up resources and stop background processes like the resource tracker.
vstinner added tests vstinner requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners
gvanrossum changed the title Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
gvanrossum left a comment
gvanrossum left a comment There was a problem hiding this comment.
Gah. Why do we have compileall and py_compile in the stdlib. :-( (That's a rhetorical question.)
miss-islington commented Sep 12, 2023
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…mpileall (pythonGH-109298) test_asyncio and test_compileall now clean up multiprocessing by calling multiprocessing _cleanup_tests(): explicitly clean up resources and stop background processes like the resource tracker. (cherry picked from commit 09ea4b8) Co-authored-by: Victor Stinner <vstinner@python.org>
…mpileall (pythonGH-109298) test_asyncio and test_compileall now clean up multiprocessing by calling multiprocessing _cleanup_tests(): explicitly clean up resources and stop background processes like the resource tracker. (cherry picked from commit 09ea4b8) Co-authored-by: Victor Stinner <vstinner@python.org>
GH-109301 is a backport of this pull request to the 3.12 branch. |
GH-109302 is a backport of this pull request to the 3.11 branch. |
vstinner commented Sep 12, 2023
Well, why do we have asyncio and multiprocessing in the stlidb? Why do you have a stdlib? (That's a rhetorical question.) 😂 |
vstinner commented Sep 12, 2023
I would prefer that multiprocessing and concurrent.futures would have a more explicit API to manage resources. Rather than spawning processes in the background with no public API to be aware of that, nor an API to cleanup these processes. There are temporary directories, processes, shared memory, etc. Not trivial resources like a single large memory block. |
…ompileall (GH-109298) (#109302) gh-109295: Clean up multiprocessing in test_asyncio and test_compileall (GH-109298) test_asyncio and test_compileall now clean up multiprocessing by calling multiprocessing _cleanup_tests(): explicitly clean up resources and stop background processes like the resource tracker. (cherry picked from commit 09ea4b8) Co-authored-by: Victor Stinner <vstinner@python.org>
…ompileall (GH-109298) (#109301) gh-109295: Clean up multiprocessing in test_asyncio and test_compileall (GH-109298) test_asyncio and test_compileall now clean up multiprocessing by calling multiprocessing _cleanup_tests(): explicitly clean up resources and stop background processes like the resource tracker. (cherry picked from commit 09ea4b8) Co-authored-by: Victor Stinner <vstinner@python.org>
…mpileall (python#109298) test_asyncio and test_compileall now clean up multiprocessing by calling multiprocessing _cleanup_tests(): explicitly clean up resources and stop background processes like the resource tracker.
3 participants
test_asyncio and test_compileall now clean up multiprocessing by calling _cleanup_tests() method: explicitly clean up resources and stop background processes like the resource tracker.