gh-108303: Move all math files to Lib/test/mathdata/

[sobolevn]

This one is pretty straight-forward. All math data now lives in a specialized place.

• Issue: Move test files into test subdirectories #108303

[vstinner]

I dislike "data" directories.

It seems like test_math uses 3 data files which are only used by test_math.

test_float uses 2 data files which are only used by test_float.

For me, "data" directories are nice when data files are shared by different tests. It doesn't seem to be the case here.

What do you think of creating test_float/ and test_math/ directories instead?

[sobolevn]

What do you think of creating test_float/ and test_math/ directories instead?

I don't have any strong opinions here, for me mathdata/ seems like a more simple way of organizing tests. But, I can change it to be test_math/ (with possibly test_cmath.py inside) and test_float/

Why do I prefer the first option? Because later some other file can be added there: possibly from test_int.py or test_decimal.py or whatever. Or some test from test_math.py can reuse float test data. This is why I went with the approach in this PR.

[serhiy-storchaka]

"cmath_testcases.txt" is shared with test_cmath.

[vstinner]

"cmath_testcases.txt" is shared with test_cmath.

test_cmath uses dark black magic, it uses class inheritance:

class IsCloseTests(test_math.IsCloseTests): 

So it doesn't directly reuses "cmath_testcases.txt", but uses it "via" test_math. Oh, that's "surprising".

[vstinner]

@serhiy-storchaka approved the change, I'm not strongly against Lib/test/mathdata/ approach.

I'm just surprised that 2 test files are added there whereas they are only used by test_float. I don't see the point of "sharing" these two files. Maybe make a test_float/ directory for them?

@serhiy-storchaka: If you're fine with mathdata/ approach,go ahead and merge the PR :-)

Because later some other file can be added there: possibly from test_int.py or test_decimal.py or whatever. Or some test from test_math.py can reuse float test data.

That sounds to be be an hypothetical use case. I would prefer to stick to current test data files usage to decide how to organize them.

[serhiy-storchaka]

It also imports the path to the test data file and the parsing function from test_math, and runs tests without skipping complex numbers.

[vstinner]

I can see the point of having mathdata/ for test_math and test_cmath.

What about test_float test files?

[serhiy-storchaka]

I'm just surprised that 2 test files are added there whereas they are only used by test_float. I don't see the point of "sharing" these two files. Maybe make a test_float/ directory for them?

They could be used in tests for decimal and fractions. I am not even sure that they are not yet used there.

[vstinner]

They could be used in tests for decimal and fractions.

If tomorrow other tests start using test_float data files, we can re-consider the organization of these data files, no? Are you proposing to make this change right now?

I am not even sure that they are not yet used there.

You can easily test: remove data files, run tests, do they still pass? :-)

The purpose of #108303 is to clarify how test data files are used ;-)

[rhettinger]

To me, these kind of edits (mostly rearrangements) have no value. It is mostly just churn.

[serhiy-storchaka]

If tomorrow other tests start using test_float data files, we can re-consider the organization of these data files, no?

#109548

[vstinner]

Oh, @serhiy-storchaka made #109548 which makes mathdata/ directory more relevant :-)

[vstinner]

LGTM.

[miss-islington]

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

[miss-islington]

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

[miss-islington]

Sorry, @sobolevn and @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ed587be0d0383f2925bf7650e8ccf1bf3adc44f9 3.11

[miss-islington]

Sorry, @sobolevn and @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ed587be0d0383f2925bf7650e8ccf1bf3adc44f9 3.12

[vstinner]

Oh, this PR was outdated since PR #109548 got merged! I wrote PR #109686 to fix it.