[3.12] gh-108303: Move all certificates to Lib/test/certdata/ (GH-109489)#109682
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…nGH-109489) (cherry picked from commit e57ecf6) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington requested review from a team, 1st1, asvetlov, gvanrossum, kumaraditya303, vsajip and willingc as code owners
Member
gvanrossum commented Sep 21, 2023
Is it really a good idea to backport moving files around? |
Member
vstinner commented Sep 21, 2023
I didn't want to backport these changes, but I was asked to backport them. See the discussion: #108303 (comment) |
Member
vstinner commented Oct 4, 2023
Oh, all CIs failed on test_nntplib. I clicked on re-run failed jobs. cc @sobolevn |
Member
sobolevn commented Oct 9, 2023
@vstinner I fixed |
Member
sobolevn commented Oct 9, 2023
Done! It works. |
ContributorAuthor
miss-islington commented Oct 10, 2023
Thanks @miss-islington for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
GH-110646 is a backport of this pull request to the 3.11 branch. |
miss-islington added a commit to miss-islington/cpython that referenced this pull request Oct 10, 2023
…pythonGH-109489) (pythonGH-109682) * pythongh-108303: Move all certificates to `Lib/test/certdata/` (pythonGH-109489) (cherry picked from commit e57ecf6) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Python 3.12 backport: update also `test_nntplib`. (cherry picked from commit c2d542b) Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: T. Wouters <thomas@python.org>
vstinner pushed a commit that referenced this pull request Oct 10, 2023
GH-109489) (GH-109682) (#110646) [3.12] gh-108303: Move all certificates to `Lib/test/certdata/` (GH-109489) (GH-109682) * gh-108303: Move all certificates to `Lib/test/certdata/` (GH-109489) (cherry picked from commit e57ecf6) Python 3.12 backport: update also `test_nntplib`. (cherry picked from commit c2d542b) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: T. Wouters <thomas@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit e57ecf6)
Co-authored-by: Nikita Sobolev mail@sobolevn.me