Skip to content

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Sep 22, 2023

Replace SHORT_TIMEOUT with LONG_TIMEOUT in test_deadlock of test_concurrent_futures.

Replace SHORT_TIMEOUT with LONG_TIMEOUT in test_deadlock of test_concurrent_futures.
@vstinnervstinner added the needs backport to 3.12 only security fixes label Sep 22, 2023
@bedevere-appbedevere-appbot added awaiting review tests Tests in the Lib/test dir labels Sep 22, 2023
@vstinnervstinner merged commit 1eb1b45 into python:mainSep 22, 2023
@vstinnervstinner deleted the deadlock_timeout branch September 22, 2023 01:13
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2023
…GH-109703) Replace SHORT_TIMEOUT with LONG_TIMEOUT in test_deadlock of test_concurrent_futures. (cherry picked from commit 1eb1b45) Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

GH-109705 is a backport of this pull request to the 3.12 branch.

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 macOS 3.x has failed when building commit 1eb1b45.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/366/builds/5426) and take a look at the build logs.
  4. Check if the failure is related to this commit (1eb1b45) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/366/builds/5426

Failed tests:

  • test.test_multiprocessing_forkserver.test_manager

Summary of the results of the build (if available):

==

Click to see traceback logs
remote: Enumerating objects: 11, done. remote: Counting objects: 9% (1/11) remote: Counting objects: 18% (2/11) remote: Counting objects: 27% (3/11) remote: Counting objects: 36% (4/11) remote: Counting objects: 45% (5/11) remote: Counting objects: 54% (6/11) remote: Counting objects: 63% (7/11) remote: Counting objects: 72% (8/11) remote: Counting objects: 81% (9/11) remote: Counting objects: 90% (10/11) remote: Counting objects: 100% (11/11) remote: Counting objects: 100% (11/11), done. remote: Compressing objects: 25% (1/4) remote: Compressing objects: 50% (2/4) remote: Compressing objects: 75% (3/4) remote: Compressing objects: 100% (4/4) remote: Compressing objects: 100% (4/4), done. remote: Total 6 (delta 5), reused 2 (delta 2), pack-reused 0  From https://github.com/python/cpython * branch main -> FETCH_HEAD Note: switching to '1eb1b45183c3b8aeefe3d5d27694155741e82bbc'. You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by switching back to a branch. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -c with the switch command. Example: git switch -c <new-branch-name> Or undo this operation with: git switch - Turn off this advice by setting config variable advice.detachedHead to false HEAD is now at 1eb1b45183 gh-109702: Increase concurrent_futures deadlock timeout (#109703) Switched to and reset branch 'main' configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly./Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libpython3.13d.a(dynamic_annotations.o) has no symbols/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libpython3.13d.a(pymath.o) has no symbolsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixups ./Modules/readline.c:1256:21: warning: incompatible function pointer types assigning to 'Function *' (aka 'int (*)(const char *, int)') from 'int (void)' [-Wincompatible-function-pointer-types] rl_startup_hook = on_startup_hook;^~~~~~~~~~~~~~~~ ./Modules/readline.c:1258:23: warning: incompatible function pointer types assigning to 'Function *' (aka 'int (*)(const char *, int)') from 'int (void)' [-Wincompatible-function-pointer-types] rl_pre_input_hook = on_pre_input_hook;^~~~~~~~~~~~~~~~~~ 2 warnings generated. ld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixupsld: warning: -undefined dynamic_lookup may not work with chained fixups Kill <WorkerThread #2 running test=test_math pid=49775 time=48.3 sec> process group Warning -- Failed to join <WorkerThread #2 running test=test_math pid=49775 time=1 min 18 sec> in 30.4 sec make: *** [buildbottest] Error 5

@vstinnervstinner added the needs backport to 3.11 only security fixes label Sep 22, 2023
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2023
…GH-109703) Replace SHORT_TIMEOUT with LONG_TIMEOUT in test_deadlock of test_concurrent_futures. (cherry picked from commit 1eb1b45) Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

GH-109708 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11 only security fixes label Sep 22, 2023
vstinner added a commit that referenced this pull request Sep 22, 2023
…9703) (#109708) gh-109702: Increase concurrent_futures deadlock timeout (GH-109703) Replace SHORT_TIMEOUT with LONG_TIMEOUT in test_deadlock of test_concurrent_futures. (cherry picked from commit 1eb1b45) Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO + PGO 3.x has failed when building commit 1eb1b45.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/442/builds/5016) and take a look at the build logs.
  4. Check if the failure is related to this commit (1eb1b45) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/442/builds/5016

Failed tests:

  • test_eintr

Failed subtests:

  • test_lockf - main.FNTLEINTRTest.test_lockf
  • test_all - test.test_eintr.EINTRTests.test_all

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/test/test_eintr.py", line 17, in test_all script_helper.run_test_script(script) File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/test/support/script_helper.py", line 300, in run_test_scriptraiseAssertionError(f"{name} failed") AssertionError: script _test_eintr.py failed Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/test/_test_eintr.py", line 523, in test_lockfself._lock(fcntl.lockf, "lockf") File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/test/_test_eintr.py", line 515, in _lockself.assertGreaterEqual(dt, self.sleep_time) AssertionError: 0.19762988499132916 not greater than or equal to 0.2

csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
…#109703) Replace SHORT_TIMEOUT with LONG_TIMEOUT in test_deadlock of test_concurrent_futures.
Yhg1s pushed a commit that referenced this pull request Oct 2, 2023
…9703) (#109705) gh-109702: Increase concurrent_futures deadlock timeout (GH-109703) Replace SHORT_TIMEOUT with LONG_TIMEOUT in test_deadlock of test_concurrent_futures. (cherry picked from commit 1eb1b45) Co-authored-by: Victor Stinner <vstinner@python.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…#109703) Replace SHORT_TIMEOUT with LONG_TIMEOUT in test_deadlock of test_concurrent_futures.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@miss-islington@bedevere-bot