Skip to content

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commented Sep 22, 2023

…-109513) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>. (cherry picked from commit 4dd47c6) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@vstinner
Copy link
Member

Tests fail:

ERROR: test_find_module_encoding (test.test_imp.ImportTests.test_find_module_encoding) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_imp.py", line 83, in test_find_module_encoding imp.find_module('badsyntax_pep3120', path) File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/imp.py", line 297, in find_module raise ImportError(_ERR_MSG.format(name), name=name) ImportError: No module named 'badsyntax_pep3120' 

@sobolevn
Copy link
MemberAuthor

test_imp is missing in 3.12 and 3.13, fixed 👍

@ambv
Copy link
Contributor

ambv commented Sep 22, 2023

There's still three failures that survive re-runs:

ERROR: test_inline_table_recursion_limit (test.test_tomllib.test_misc.TestMiscellaneous.test_inline_table_recursion_limit) (limit=137, available=99, nest_count=32) FAIL: test_get_recursion_depth (test.test_support.TestSupport.test_get_recursion_depth) ERROR: test_recursion (test.test_support.TestSupport.test_recursion) 

All are about exceeded recursion limits.

@AlexWaygood
Copy link
Member

ERROR: test_inline_table_recursion_limit (test.test_tomllib.test_misc.TestMiscellaneous.test_inline_table_recursion_limit) (limit=137, available=99, nest_count=32)

That one's been failing on the 3.11 branch for a while now, I think, FWIW. Don't know about the others.

@vstinner
Copy link
Member

ERROR: test_inline_table_recursion_limit (test.test_tomllib.test_misc.TestMiscellaneous.test_inline_table_recursion_limit) (limit=137, available=99, nest_count=32)
FAIL: test_get_recursion_depth (test.test_support.TestSupport.test_get_recursion_depth)
ERROR: test_recursion (test.test_support.TestSupport.test_recursion)

Sadly, these ones are regressions when I fixed a RecursionError :-( See issue GH-108851.

@vstinnervstinner merged commit 6bb18bb into python:3.11Sep 22, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn@vstinner@ambv@AlexWaygood