Skip to content

[3.12] gh-109833: Fix asyncio test_wait_for() (GH-109834)#109837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Yhg1s merged 1 commit into from
Oct 2, 2023
Merged

[3.12] gh-109833: Fix asyncio test_wait_for() (GH-109834) #109837

Yhg1s merged 1 commit into from
Oct 2, 2023

Conversation

@miss-islington
Copy link
Contributor

@miss-islingtonmiss-islington commented Sep 25, 2023•
edited by bedevere-app bot
Loading

Expect the test to be "short" but don't measure the exact performance
of the CI. SHORT_TIMEOUT is about 30 seconds whereas the cancelled
coroutine takes around 1 hour.
(cherry picked from commit f29bc9c)

Co-authored-by: Victor Stinner [email protected]

@vstinner@miss-islington
pythongh-109833: Fix asyncio test_wait_for() (pythonGH-109834)
2ef4f9d
Expect the test to be "short" but don't measure the exact performance of the CI. SHORT_TIMEOUT is about 30 seconds whereas the cancelled coroutine takes around 1 hour. (cherry picked from commit f29bc9c) Co-authored-by: Victor Stinner <[email protected]>
@bedevere-appbedevere-appbot added awaiting review tests Tests in the Lib/test dir labels Sep 25, 2023
This was referenced Sep 25, 2023
Closed
Merged
vstinner
vstinner approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot

@Yhg1sYhg1s merged commit 150bd30 into python:3.12Oct 2, 2023
@miss-islingtonmiss-islington deleted the backport-f29bc9c-3.12 branch October 2, 2023 15:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@gvanrossumgvanrossumAwaiting requested review from gvanrossumgvanrossum is a code owner

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miss-islington@vstinner@Yhg1s