Skip to content

Conversation

@AA-Turner
Copy link
Member

@AA-TurnerAA-Turner commented Sep 26, 2023

@AA-TurnerAA-Turnerforce-pushed the patchcheck/delete-azure-pipelines branch from d707f5c to 269bebeCompareJuly 26, 2024 22:30
@AA-TurnerAA-Turner marked this pull request as ready for review July 26, 2024 23:04
@AA-Turner
Copy link
MemberAuthor

If I understand Éric's comments correctly, they don't block this PR itself, but more speak to improving the experience of running CPython's linting tools. In an effort to unblock this PR, I have opened #122333 as a sketch proposal.

A

@merwok
Copy link
Member

I’m not active enough for my comments to have weight here. But you could have a discussion in the core-dev discuss forum to check agreement and avoid people being surprised after the fact.

@AA-Turner
Copy link
MemberAuthor

But you could have a discussion in the core-dev discuss forum to check agreement and avoid people being surprised after the fact.

We did last year (https://discuss.python.org/t/34743), which I don't think raised any opposition to removing the (now duplicative) whitespace checks in CI. The wider patchcheck tool will remain, and #122333 will hopefully give us a unified 'local static checks' target. If/when that's merged, I think telling people on Discourse as a reminder would be useful.

A

@hugovkhugovk changed the title GH-109408: Stop running patchcheck in CIgh-109408: Stop running patchcheck in CIJul 27, 2024
@AA-Turner
Copy link
MemberAuthor

It's been a week or so with no comment (and a year since the PR was opened), so I'll go ahead and merge this. If things go wrong we can always revert.

A

@AA-TurnerAA-Turner merged commit cc6839a into python:mainAug 3, 2024
@AA-TurnerAA-Turner deleted the patchcheck/delete-azure-pipelines branch August 3, 2024 11:52
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@AA-Turner@merwok@hugovk