Skip to content

Conversation

@colesbury
Copy link
Contributor

@colesburycolesbury commented Sep 26, 2023

Shared libraries for CPython 3.13 --disable-gil builds are now marked with a 't' for threading. For example, binascii.cpython-313t-darwin.so.

Shared libraries for CPython 3.13 are now marked with a 't' for threading. For example, `binascii.cpython-313t-darwin.so`.
@colesbury
Copy link
ContributorAuthor

colesbury commented Sep 26, 2023

Notes for reviewers:

  • I moved the --disable-gil flag up in configure so that it comes before the debug check so that the optional "d" ABI flag appears on the outside (e.g., package-cpython-313td-darwin.so for --disable-gil --with-pydebug). This is purely aesthetic and can be changed, if you prefer.
  • Contrary to what I originally thought, pypa/packaging will need to be updated to compute CPython tags for --disable-gil builds.

…WdQ.rst Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but i left a few minor suggestions.

Copy link
Member

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vstinnervstinner enabled auto-merge (squash) September 27, 2023 08:07
@vstinner
Copy link
Member

I included my suggested changes to be able to merge your PR more quickly ;-)

@erlend-aasland
Copy link
Contributor

I included my suggested changes to be able to merge your PR more quickly ;-)

You need to regen configure.

@vstinnervstinner enabled auto-merge (squash) September 27, 2023 08:39
@vstinner
Copy link
Member

You need to regen configure.

Oops. Otherwise, it would be too easy! Done.

@colesbury
Copy link
ContributorAuthor

Thanks!

@vstinner
Copy link
Member

Windows x64 unstable tests:

FAIL: test_future_times_out (test.test_concurrent_futures.test_as_completed.ThreadPoolAsCompletedTest.test_future_times_out) [0.01]

Should be already fixed by PR #109949.

FAIL: test_set_and_clear (test.test_threading.EventTests.test_set_and_clear)

I created issue #109974 for this failure.

@vstinnervstinner merged commit 773614e into python:mainSep 27, 2023
@vstinner
Copy link
Member

Good, it got merged after a few CI hiccups :-)

@colesburycolesbury deleted the abi branch September 27, 2023 15:29
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
Shared libraries for CPython 3.13 are now marked with a 't' for threading. For example, `binascii.cpython-313t-darwin.so`.
@vstinner
Copy link
Member

The test broke test_importlib on Windows: see issue gh-110359.

FAIL: test_tagged_suffix (test.test_importlib.test_windows.Source_WindowsExtensionSuffixTests.test_tagged_suffix) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_importlib\test_windows.py", line 122, in test_tagged_suffix self.assertIn(expected_tag, suffixes) AssertionError: '_d.cp313-win32.pyd' not found in ['_d.cp313t-win_amd64.pyd', '_d.pyd'] 

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Shared libraries for CPython 3.13 are now marked with a 't' for threading. For example, `binascii.cpython-313t-darwin.so`.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@colesbury@vstinner@erlend-aasland@corona10