Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-109740: Use 't' in --disable-gil SOABI#109922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
colesbury commented Sep 26, 2023 • edited by bedevere-app bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-app bot
Uh oh!
There was an error while loading. Please reload this page.
Shared libraries for CPython 3.13 are now marked with a 't' for threading. For example, `binascii.cpython-313t-darwin.so`.
colesbury commented Sep 26, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Notes for reviewers:
|
Misc/NEWS.d/next/Build/2023-09-26-16-00-50.gh-issue-109740.wboWdQ.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
…WdQ.rst Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but i left a few minor suggestions.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
corona10 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
vstinner commented Sep 27, 2023
I included my suggested changes to be able to merge your PR more quickly ;-) |
erlend-aasland commented Sep 27, 2023
You need to regen configure. |
vstinner commented Sep 27, 2023
Oops. Otherwise, it would be too easy! Done. |
colesbury commented Sep 27, 2023
Thanks! |
vstinner commented Sep 27, 2023
Windows x64 unstable tests:
Should be already fixed by PR #109949.
I created issue #109974 for this failure. |
vstinner commented Sep 27, 2023
Good, it got merged after a few CI hiccups :-) |
Shared libraries for CPython 3.13 are now marked with a 't' for threading. For example, `binascii.cpython-313t-darwin.so`.
vstinner commented Oct 4, 2023
The test broke test_importlib on Windows: see issue gh-110359. |
Shared libraries for CPython 3.13 are now marked with a 't' for threading. For example, `binascii.cpython-313t-darwin.so`.
Shared libraries for CPython 3.13
--disable-gilbuilds are now marked with a 't' for threading. For example,binascii.cpython-313t-darwin.so.--disable-gilbuilds #109740