Skip to content

[3.12] gh-101100: Fix Sphinx warnings in Doc/using/configure.rst (GH-109931)#109937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Yhg1s merged 2 commits into from
Sep 28, 2023
Merged

[3.12] gh-101100: Fix Sphinx warnings in Doc/using/configure.rst (GH-109931) #109937

Yhg1s merged 2 commits into from
Sep 28, 2023

Conversation

@miss-islington
Copy link
Contributor

@miss-islingtonmiss-islington commented Sep 27, 2023•
edited by github-actions bot
Loading

(cherry picked from commit 3538930)

Co-authored-by: Victor Stinner vstinner@python.org

📚 Documentation preview 📚: https://cpython-previews--109937.org.readthedocs.build/

@vstinner@miss-islington
pythongh-101100: Fix Sphinx warnings in Doc/using/configure.rst (pyth…
e1de39b
…onGH-109931) (cherry picked from commit 3538930) Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-appbedevere-appbot mentioned this pull request Sep 27, 2023
Open
@bedevere-appbedevere-appbot mentioned this pull request Sep 27, 2023
Merged
vstinner
vstinner approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Sep 27, 2023

This breaks the Docs CI:

Error: must not contain warnings: Doc/using/configure.rst 772: c:macro reference target not found: PyAPI_FUNC() 772: c:macro reference target not found: PyAPI_DATA() 772: c:macro reference target not found: PyMODINIT_FUNC Error: Process completed with exit code 255.

@vstinner
Copy link
Member

vstinner commented Sep 27, 2023

This breaks the Docs CI:
772: c:macro reference target not found: PyAPI_FUNC()
772: c:macro reference target not found: PyAPI_DATA()
772: c:macro reference target not found: PyMODINIT_FUNC

Oh, I forgot to backport other Sphinx warnings fixed: PR #109236. I just created PR #109947 for Python 3.12: it should be merged before this PR.

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Sep 27, 2023

Great, thanks!

@Yhg1sYhg1s merged commit 60046a7 into python:3.12Sep 28, 2023
@miss-islingtonmiss-islington deleted the backport-3538930-3.12 branch September 28, 2023 15:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington@erlend-aasland@vstinner@Yhg1s