bpo-29474: Improve documentation for weakref.WeakValueDictionary#11
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There were some grammatical errors in weakref.WeakValueDictionary documentation. This is to be applied to 2.7
zware approved these changes Feb 11, 2017
Member
zware left a comment
zware left a comment There was a problem hiding this comment.
Trusting that the sentence makes sense in context, this does indeed fix the grammar. LGTM.
MemberAuthor
Mariatta commented Feb 12, 2017
Thanks for the reviews, @zware :) |
paulmon added a commit to paulmon/cpython that referenced this pull request Jan 10, 2019
pip requires distutils
emmatyping referenced this pull request in emmatyping/cpython Feb 24, 2020
nanjekyejoannah added a commit to nanjekyejoannah/cpython that referenced this pull request Nov 17, 2022
11: Warn for function attributes r=ltratt a=nanjekyejoannah Warn for function attributes Co-authored-by: Joannah Nanjekye <[email protected]>
This was referenced Feb 11, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some grammatical errors in weakref.WeakValueDictionary
documentation.
This is to be applied to 2.7