Skip to content

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Sep 29, 2023

concurrent.futures: The executor manager thread now catches exceptions when adding an item to the call queue. During Python finalization, creating a new thread can now raise RuntimeError. Catch the exception and call terminate_broken() in this case.

Add test_python_finalization_error() to test_concurrent_futures.

concurrent.futures._ExecutorManagerThread changes:

  • terminate_broken() no longer calls shutdown_workers() since the call queue is no longer working anymore (read and write ends of the queue pipe are closed).
  • terminate_broken() now terminates child processes, not only wait until they complete.
  • _ExecutorManagerThread.terminate_broken() now holds shutdown_lock to prevent race conditons with ProcessPoolExecutor.submit().

multiprocessing.Queue changes:

  • Add _terminate_broken() method.
  • _start_thread() sets _thread to None on exception to prevent leaking "dangling threads" even if the thread was not started yet.

(cherry picked from commit 6351842)

…ython#109810) concurrent.futures: The *executor manager thread* now catches exceptions when adding an item to the *call queue*. During Python finalization, creating a new thread can now raise RuntimeError. Catch the exception and call terminate_broken() in this case. Add test_python_finalization_error() to test_concurrent_futures. concurrent.futures._ExecutorManagerThread changes: * terminate_broken() no longer calls shutdown_workers() since the call queue is no longer working anymore (read and write ends of the queue pipe are closed). * terminate_broken() now terminates child processes, not only wait until they complete. * _ExecutorManagerThread.terminate_broken() now holds shutdown_lock to prevent race conditons with ProcessPoolExecutor.submit(). multiprocessing.Queue changes: * Add _terminate_broken() method. * _start_thread() sets _thread to None on exception to prevent leaking "dangling threads" even if the thread was not started yet. (cherry picked from commit 6351842)
@vstinnervstinner changed the title gh-109047: concurrent.futures catches PythonFinalizationError (#109810)[3.12] gh-109047: concurrent.futures catches RuntimeError (#109810)Sep 29, 2023
@rhettingerrhettinger removed their request for review September 30, 2023 17:32
@Yhg1sYhg1s merged commit 356de02 into python:3.12Oct 2, 2023
@vstinnervstinner deleted the cf_finalization_error12 branch January 14, 2025 08:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner@Yhg1s