Skip to content

Conversation

@denballakh
Copy link
Contributor

@denballakhdenballakh commented Oct 2, 2023

@JelleZijlstraJelleZijlstra added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 7, 2023
@JelleZijlstraJelleZijlstra merged commit dd9d781 into python:mainOct 8, 2023
@miss-islington
Copy link
Contributor

Thanks @denballakh for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2023
…ass` (pythonGH-110238) (cherry picked from commit dd9d781) Co-authored-by: denballakh <47365157+denballakh@users.noreply.github.com>
@bedevere-app
Copy link

GH-110511 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Oct 8, 2023
@bedevere-app
Copy link

GH-110512 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11 only security fixes label Oct 8, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2023
…ass` (pythonGH-110238) (cherry picked from commit dd9d781) Co-authored-by: denballakh <47365157+denballakh@users.noreply.github.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit dd9d781.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/5893) and take a look at the build logs.
  4. Check if the failure is related to this commit (dd9d781) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/5893

Failed tests:

  • test_signal

Summary of the results of the build (if available):

==

Click to see traceback logs
remote: Enumerating objects: 9, done. remote: Counting objects: 12% (1/8) remote: Counting objects: 25% (2/8) remote: Counting objects: 37% (3/8) remote: Counting objects: 50% (4/8) remote: Counting objects: 62% (5/8) remote: Counting objects: 75% (6/8) remote: Counting objects: 87% (7/8) remote: Counting objects: 100% (8/8) remote: Counting objects: 100% (8/8), done. remote: Compressing objects: 12% (1/8) remote: Compressing objects: 25% (2/8) remote: Compressing objects: 37% (3/8) remote: Compressing objects: 50% (4/8) remote: Compressing objects: 62% (5/8) remote: Compressing objects: 75% (6/8) remote: Compressing objects: 87% (7/8) remote: Compressing objects: 100% (8/8) remote: Compressing objects: 100% (8/8), done. remote: Total 9 (delta 0), reused 0 (delta 0), pack-reused 1  From https://github.com/python/cpython * branch main -> FETCH_HEAD Note: switching to 'dd9d781da30aa3740e54c063a40413c542d78c25'. You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by switching back to a branch. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -c with the switch command. Example: git switch -c <new-branch-name> Or undo this operation with: git switch - Turn off this advice by setting config variable advice.detachedHead to false HEAD is now at dd9d781da3 gh-110237: Check `PyList_Append` for errors in `_PyEval_MatchClass` (#110238) Switched to and reset branch 'main' In file included from ./Modules/_tkinter.c:52: In file included from /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/tk.h:99: /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/X11/Xlib.h:131:21: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] int (*free_private)(); /* called to free private storage */^ void /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/X11/Xlib.h:334:33: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] struct _XImage *(*create_image)();^ void /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/X11/Xlib.h:453:23: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] XID (*resource_alloc)(); /* allocator function */^ void /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/X11/Xlib.h:471:20: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] int (*synchandler)(); /* Synchronization handler */^ void /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/X11/Xlib.h:496:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] Bool (*event_vec[128])(); /* vector for wire to event */^ void /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/X11/Xlib.h:497:25: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] Status (*wire_vec[128])(); /* vector for event to wire */^ void /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/X11/Xlib.h:509:20: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] Bool (**error_vec)(); /* vector for wire to error */^ void /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/X11/Xlib.h:522:25: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] int (*savedsynchandler)(); /* user synchandler when Xlib usurps */^ void /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/X11/Xlib.h:1053:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] typedef void (*XIMProc)(); ^ void In file included from ./Modules/tkappinit.c:17: In file included from /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/tk.h:99: /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/X11/Xlib.h:131:21: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] int (*free_private)(); /* called to free private storage */^ void /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/X11/Xlib.h:334:33: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] struct _XImage *(*create_image)();^ void /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/X11/Xlib.h:453:23: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] XID (*resource_alloc)(); /* allocator function */^ void /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/X11/Xlib.h:471:20: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] int (*synchandler)(); /* Synchronization handler */^ void /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/X11/Xlib.h:496:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] Bool (*event_vec[128])(); /* vector for wire to event */^ void /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/X11/Xlib.h:497:25: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] Status (*wire_vec[128])(); /* vector for event to wire */^ void /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/X11/Xlib.h:509:20: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] Bool (**error_vec)(); /* vector for wire to error */^ void /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/X11/Xlib.h:522:25: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] int (*savedsynchandler)(); /* user synchandler when Xlib usurps */^ void /opt/homebrew/Cellar/tcl-tk/8.6.13_5/include/tcl-tk/X11/Xlib.h:1053:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] typedef void (*XIMProc)(); ^ void 9 warnings generated. 9 warnings generated. make: *** [buildbottest] Error 5

JelleZijlstra pushed a commit that referenced this pull request Oct 8, 2023
…lass` (GH-110238) (#110512) gh-110237: Check `PyList_Append` for errors in `_PyEval_MatchClass` (GH-110238) (cherry picked from commit dd9d781) Co-authored-by: denballakh <47365157+denballakh@users.noreply.github.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 LTO + PGO 3.x has failed when building commit dd9d781.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/78/builds/5564) and take a look at the build logs.
  4. Check if the failure is related to this commit (dd9d781) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/78/builds/5564

Failed tests:

  • test_os

Failed subtests:

  • test_timerfd_TFD_TIMER_ABSTIME - test.test_os.TimerfdTests.test_timerfd_TFD_TIMER_ABSTIME

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/test_os.py", line 4058, in test_timerfd_TFD_TIMER_ABSTIMEself.assertGreater(t, offset) AssertionError: 0.9999975209939294 not greater than 1

JelleZijlstra pushed a commit that referenced this pull request Oct 8, 2023
…lass` (GH-110238) (#110511) gh-110237: Check `PyList_Append` for errors in `_PyEval_MatchClass` (GH-110238) (cherry picked from commit dd9d781) Co-authored-by: denballakh <47365157+denballakh@users.noreply.github.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable Clang 3.x has failed when building commit dd9d781.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/234/builds/4667) and take a look at the build logs.
  4. Check if the failure is related to this commit (dd9d781) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/234/builds/4667

Failed tests:

  • test_socket

Summary of the results of the build (if available):

==

Click to see traceback logs
remote: Enumerating objects: 14, done. remote: Counting objects: 7% (1/13) remote: Counting objects: 15% (2/13) remote: Counting objects: 23% (3/13) remote: Counting objects: 30% (4/13) remote: Counting objects: 38% (5/13) remote: Counting objects: 46% (6/13) remote: Counting objects: 53% (7/13) remote: Counting objects: 61% (8/13) remote: Counting objects: 69% (9/13) remote: Counting objects: 76% (10/13) remote: Counting objects: 84% (11/13) remote: Counting objects: 92% (12/13) remote: Counting objects: 100% (13/13) remote: Counting objects: 100% (13/13), done. remote: Compressing objects: 7% (1/13) remote: Compressing objects: 15% (2/13) remote: Compressing objects: 23% (3/13) remote: Compressing objects: 30% (4/13) remote: Compressing objects: 38% (5/13) remote: Compressing objects: 46% (6/13) remote: Compressing objects: 53% (7/13) remote: Compressing objects: 61% (8/13) remote: Compressing objects: 69% (9/13) remote: Compressing objects: 76% (10/13) remote: Compressing objects: 84% (11/13) remote: Compressing objects: 92% (12/13) remote: Compressing objects: 100% (13/13) remote: Compressing objects: 100% (13/13), done. remote: Total 14 (delta 1), reused 0 (delta 0), pack-reused 1  From https://github.com/python/cpython * branch main -> FETCH_HEAD Note: switching to 'dd9d781da30aa3740e54c063a40413c542d78c25'. You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by switching back to a branch. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -c with the switch command. Example: git switch -c <new-branch-name> Or undo this operation with: git switch - Turn off this advice by setting config variable advice.detachedHead to false HEAD is now at dd9d781da3 gh-110237: Check `PyList_Append` for errors in `_PyEval_MatchClass` (#110238) Switched to and reset branch 'main' make: *** [Makefile:2021: buildbottest] Error 5

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora 3.x has failed when building commit dd9d781.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/223/builds/4624) and take a look at the build logs.
  4. Check if the failure is related to this commit (dd9d781) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/223/builds/4624

Failed tests:

  • test_os

Failed subtests:

  • test_timerfd_ns_TFD_TIMER_ABSTIME - test.test_os.TimerfdTests.test_timerfd_ns_TFD_TIMER_ABSTIME

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z/build/Lib/test/test_os.py", line 4211, in test_timerfd_ns_TFD_TIMER_ABSTIMEself.assertGreater(t, offset_ns) AssertionError: 999999608 not greater than 1000000000

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x has failed when building commit dd9d781.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/345/builds/6036) and take a look at the build logs.
  4. Check if the failure is related to this commit (dd9d781) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/345/builds/6036

Failed tests:

  • test.test_concurrent_futures.test_shutdown

Failed subtests:

  • test_interpreter_shutdown - test.test_concurrent_futures.test_shutdown.ProcessPoolSpawnProcessPoolShutdownTest.test_interpreter_shutdown

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_concurrent_futures/test_shutdown.py", line 50, in test_interpreter_shutdownself.assertEqual(out.strip(), b"apple") AssertionError: b'' != b'apple'

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Arch Linux Asan Debug 3.x has failed when building commit dd9d781.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/585/builds/4168) and take a look at the build logs.
  4. Check if the failure is related to this commit (dd9d781) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/585/builds/4168

Failed tests:

  • test_os

Failed subtests:

  • test_timerfd_TFD_TIMER_ABSTIME - test.test_os.TimerfdTests.test_timerfd_TFD_TIMER_ABSTIME

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64.asan_debug/build/Lib/test/test_os.py", line 4058, in test_timerfd_TFD_TIMER_ABSTIMEself.assertGreater(t, offset) AssertionError: 0.9999996839906089 not greater than 1

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable LTO 3.x has failed when building commit dd9d781.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/336/builds/4149) and take a look at the build logs.
  4. Check if the failure is related to this commit (dd9d781) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/336/builds/4149

Failed tests:

  • test_os

Failed subtests:

  • test_timerfd_TFD_TIMER_ABSTIME - test.test_os.TimerfdTests.test_timerfd_TFD_TIMER_ABSTIME

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/test_os.py", line 4058, in test_timerfd_TFD_TIMER_ABSTIMEself.assertGreater(t, offset) AssertionError: 0.999941215995932 not greater than 1

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Clang Installed 3.x has failed when building commit dd9d781.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/531/builds/4641) and take a look at the build logs.
  4. Check if the failure is related to this commit (dd9d781) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/531/builds/4641

Failed tests:

  • test_subprocess

Failed subtests:

  • test_pipesize_default - test.test_subprocess.ProcessTestCaseNoPoll.test_pipesize_default
  • test_pipesizes - test.test_subprocess.ProcessTestCaseNoPoll.test_pipesizes
  • test_pipesize_default - test.test_subprocess.ProcessTestCase.test_pipesize_default
  • test_pipesizes - test.test_subprocess.ProcessTestCase.test_pipesizes

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.13/test/test_subprocess.py", line 769, in test_pipesize_defaultself.assertEqual( AssertionError: 65536 != 8192 Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.13/test/test_subprocess.py", line 727, in test_pipesizes p = subprocess.Popen( ^^^^^^^^^^^^^^^^^ File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.13/subprocess.py", line 992, in __init__ errread, errwrite) =self._get_handles(stdin, stdout, stderr) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.13/subprocess.py", line 1731, in _get_handles fcntl.fcntl(errwrite, fcntl.F_SETPIPE_SZ, self.pipesize) PermissionError: [Errno 1] Operation not permitted

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 LTO + PGO 3.x has failed when building commit dd9d781.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/458/builds/4130) and take a look at the build logs.
  4. Check if the failure is related to this commit (dd9d781) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/458/builds/4130

Failed tests:

  • test_os

Failed subtests:

  • test_timerfd_TFD_TIMER_ABSTIME - test.test_os.TimerfdTests.test_timerfd_TFD_TIMER_ABSTIME

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto-pgo/build/Lib/test/test_os.py", line 4058, in test_timerfd_TFD_TIMER_ABSTIMEself.assertGreater(t, offset) AssertionError: 0.9999993200181052 not greater than 1

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE Fedora Stable LTO + PGO 3.x has failed when building commit dd9d781.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/101/builds/3856) and take a look at the build logs.
  4. Check if the failure is related to this commit (dd9d781) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/101/builds/3856

Failed tests:

  • test_os

Failed subtests:

  • test_timerfd_TFD_TIMER_ABSTIME - test.test_os.TimerfdTests.test_timerfd_TFD_TIMER_ABSTIME

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.lto-pgo/build/Lib/test/test_os.py", line 4058, in test_timerfd_TFD_TIMER_ABSTIMEself.assertGreater(t, offset) AssertionError: 0.9999845158308744 not greater than 1

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Clang Installed 3.11 has failed when building commit f21c09c.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/958/builds/988) and take a look at the build logs.
  4. Check if the failure is related to this commit (f21c09c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/958/builds/988

Failed tests:

  • test_subprocess

Failed subtests:

  • test_pipesize_default - test.test_subprocess.ProcessTestCaseNoPoll.test_pipesize_default
  • test_pipesizes - test.test_subprocess.ProcessTestCaseNoPoll.test_pipesizes
  • test_pipesize_default - test.test_subprocess.ProcessTestCase.test_pipesize_default
  • test_pipesizes - test.test_subprocess.ProcessTestCase.test_pipesizes

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.11.edelsohn-fedora-z.clang-installed/build/target/lib/python3.11/test/test_subprocess.py", line 767, in test_pipesize_defaultself.assertEqual( AssertionError: 65536 != 8192 Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.11.edelsohn-fedora-z.clang-installed/build/target/lib/python3.11/test/test_subprocess.py", line 725, in test_pipesizes p = subprocess.Popen( ^^^^^^^^^^^^^^^^^ File "/home/dje/cpython-buildarea/3.11.edelsohn-fedora-z.clang-installed/build/target/lib/python3.11/subprocess.py", line 992, in __init__ errread, errwrite) =self._get_handles(stdin, stdout, stderr) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/dje/cpython-buildarea/3.11.edelsohn-fedora-z.clang-installed/build/target/lib/python3.11/subprocess.py", line 1731, in _get_handles fcntl.fcntl(errwrite, fcntl.F_SETPIPE_SZ, self.pipesize) PermissionError: [Errno 1] Operation not permitted

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing error checks in _PyEval_MatchClass

4 participants

@denballakh@miss-islington@bedevere-bot@JelleZijlstra