Skip to content

Conversation

@hugovk
Copy link
Member

In 2020, PR #19909 added Misc/requirements-test.txt and installed it as part of .github/workflows/coverage.yml and .travis.yml.

In 2021, however, PRs #25679 and #30257 removed those CI files, so Misc/requirements-test.txt is unused.

Let's remove it.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovkhugovk merged commit 1001233 into python:mainOct 3, 2023
@hugovkhugovk deleted the rm-requirements-test.txt branch October 3, 2023 05:01
@miss-islington
Copy link
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-app
Copy link

GH-110253 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2023
(cherry picked from commit 1001233) Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Oct 3, 2023
@bedevere-app
Copy link

GH-110254 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11 only security fixes label Oct 3, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2023
(cherry picked from commit 1001233) Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Oct 3, 2023
hugovk added a commit that referenced this pull request Oct 3, 2023
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@hugovk@miss-islington@vstinner@AA-Turner