gh-104909: Split more LOAD_ATTR specializations#110317
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
gvanrossum commented Oct 3, 2023
Oh. Test failures: test_bz2 and test_lzma. Bisecting. |
MemberAuthor
gvanrossum commented Oct 4, 2023
I'm not sure I believe it, but the benchmarks say tthis is 1% faster:
|
Member
markshannon commented Oct 4, 2023
Looks good. |
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
* Split LOAD_ATTR_MODULE * Split LOAD_ATTR_WITH_HINT * Split _GUARD_TYPE_VERSION out of the latter * Split LOAD_ATTR_CLASS * Split LOAD_ATTR_NONDESCRIPTOR_WITH_VALUES * Fix indent of DEOPT_IF in macros * Split LOAD_ATTR_METHOD_LAZY_DICT * Split LOAD_ATTR_NONDESCRIPTOR_NO_DICT * Fix omission of _CHECK_ATTR_METHOD_LAZY_DICT
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split the following
LOAD_ATTRspecializations:LOAD_ATTR_NONDESCRIPTOR_NO_DICTLOAD_ATTR_METHOD_LAZY_DICTLOAD_ATTR_NONDESCRIPTOR_WITH_VALUESLOAD_ATTR_CLASSLOAD_ATTR_WITH_HINTLOAD_ATTR_MODULEThis also contains a cosmetic fix regarding the indentation of
DEOPT_IF()macros.The following two are the only
LOAD_ATTRspecialization that aren't split up yet:LOAD_ATTR_PROPERTY(looks complicated)LOAD_ATTR_GETATTRIBUTE_OVERRIDDEN(not used in the benchmark)