gh-110514: Add PY_THROW to sys.setprofile events#110524
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gaogaotiantian added 3.12 
Member
markshannon commented Oct 9, 2023
Thanks, looks good. |
Contributor
miss-islington commented Oct 9, 2023
Thanks @gaogaotiantian for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 9, 2023
GH-110541 is a backport of this pull request to the 3.12 branch. |
Yhg1s pushed a commit that referenced this pull request Oct 9, 2023
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sys.setprofilesuffers the same issue as #106161 - it does not recordPY_THROWevents. So when the generator is garbage collected, the count is wrong.For
profilemodule, that means an assertion is raised.This needs backporting.
AssertionErrorwhen runningprofileon code containing generator expression #110514