gh-110525: Cover PySet_Add corner case with frozenset objects#110544
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
3 tasks
serhiy-storchaka approved these changes Oct 9, 2023
Member
serhiy-storchaka left a comment
serhiy-storchaka left a comment There was a problem hiding this comment.
There is a leak of num.
MemberAuthor
Thanks for the catch! Fixed. |
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
sobolevn commented Oct 9, 2023
Counting references in your head is exausting! |
serhiy-storchaka approved these changes Oct 9, 2023
Member
serhiy-storchaka commented Oct 9, 2023
Then we probably wouldn't need Python. |
Contributor
miss-islington commented Oct 9, 2023
Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 9, 2023
…ythonGH-110544) (cherry picked from commit ea39c87) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
GH-110554 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka pushed a commit that referenced this pull request Oct 9, 2023
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corner case cannot be covered from Python code, as far as I can tell. But, it is documented:
So, I think we need to test it as well in C code. Sorry for missing this in the original PR!
setandfrozenset#110525