Skip to content

gh-84570: Implement Waiting in SendChannel.send()#110565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericsnowcurrently merged 7 commits into from
Oct 10, 2023
Merged

gh-84570: Implement Waiting in SendChannel.send() #110565

ericsnowcurrently merged 7 commits into from
Oct 10, 2023

Conversation

@ericsnowcurrently
Copy link
Member

@ericsnowcurrentlyericsnowcurrently commented Oct 9, 2023•
edited by bedevere-app bot
Loading

We had been faking it (poorly).

We will add timeouts separately.

@ericsnowcurrentlyericsnowcurrently changed the title Implement Waiting in SendChannel.send()gh-84570: Implement Waiting in SendChannel.send()Oct 9, 2023
@bedevere-appbedevere-appbot mentioned this pull request Oct 9, 2023
Closed
@ericsnowcurrentlyericsnowcurrently mentioned this pull request Oct 9, 2023
Closed
@ericsnowcurrentlyericsnowcurrently enabled auto-merge (squash) October 10, 2023 09:23
@ericsnowcurrentlyericsnowcurrently merged commit 757cc35 into python:mainOct 10, 2023
@ericsnowcurrentlyericsnowcurrently deleted the channel-send-wait-new branch October 10, 2023 09:38
@ericsnowcurrentlyericsnowcurrently mentioned this pull request Oct 17, 2023
Merged
ericsnowcurrently added a commit that referenced this pull request Oct 17, 2023
@ericsnowcurrently
gh-84570: Send-Wait Fixes for _xxinterpchannels (gh-111006)
a53d7cb
There were a few things I did in gh-110565 that need to be fixed. I also forgot to add tests in that PR. (Note that this PR exposes a refleak introduced by gh-110246. I'll take care of that separately.)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@ericsnowcurrently@aisk
pythongh-84570: Send-Wait Fixes for _xxinterpchannels (pythongh-111006)
0301f3b
There were a few things I did in pythongh-110565 that need to be fixed. I also forgot to add tests in that PR. (Note that this PR exposes a refleak introduced by pythongh-110246. I'll take care of that separately.)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@ericsnowcurrently@Glyphack
pythongh-84570: Implement Waiting in SendChannel.send() (pythongh-110565
6290e1a
) We had been faking it (poorly). We will add timeouts separately.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@ericsnowcurrently@Glyphack
pythongh-84570: Send-Wait Fixes for _xxinterpchannels (pythongh-111006)
934d648
There were a few things I did in pythongh-110565 that need to be fixed. I also forgot to add tests in that PR. (Note that this PR exposes a refleak introduced by pythongh-110246. I'll take care of that separately.)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ericsnowcurrently