Skip to content

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygoodAlexWaygood commented Oct 10, 2023

These are more opinionated, lint-style checks than the existing pyflakes rules that we currently have enabled on Argument Clinic, following #110559. The full list of pyupgrade rules is at https://docs.astral.sh/ruff/rules/#pyupgrade-up.

Thoughts? Is this a useful addition?

@AlexWaygood
Copy link
MemberAuthor

Thanks, both! I chatted with @hugovk at the sprint (you're missed @erlend-aasland 😢), and I think there probably aren't any other rules that are worth enabling right now (but feel free to propose any more that that you think would be useful!)

@AlexWaygoodAlexWaygood enabled auto-merge (squash) October 10, 2023 09:14
@erlend-aasland
Copy link
Contributor

Thanks, both! I chatted with @hugovk at the sprint (you're missed @erlend-aasland 😢), and I think there probably aren't any other rules that are worth enabling right now (but feel free to propose any more that that you think would be useful!)

For these DevOps things, I fully trust you two! :) It is very nice that we're getting more automated machinery in place in the CPython repo; I love it! I wish I was in Brno with y'all; it is a very nice city IMO.

@AlexWaygoodAlexWaygood merged commit fc811c8 into python:mainOct 10, 2023
@AlexWaygoodAlexWaygood deleted the ruff-pyupgrade-argclinic branch October 10, 2023 09:35
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-app
Copy link

GH-110609 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Oct 10, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2023
…nt Clinic (pythonGH-110603) (cherry picked from commit fc811c8) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Oct 10, 2023
…ent Clinic (GH-110603) (#110609) gh-110558: Enable ruff's pyupgrade rules when running on Argument Clinic (GH-110603) (cherry picked from commit fc811c8) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexWaygood@erlend-aasland@miss-islington@hugovk