[3.8] gh-108310: Fix TestPreHandshakeClose tests in test_ssl#110718
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The new class is part of the fix for CVE-2023-40217: python@b4bcc06 but it's not in the lists of tests so they're not executed. The new tests also need `SHORT_TIMEOUT` constant not available in test.support in 3.8.
2 tasks
ambv changed the title 
gpshead approved these changes Oct 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new class is part of the fix for CVE-2023-40217: b4bcc06 but it's not in the lists of tests so they're not
executed. The new tests also need
SHORT_TIMEOUTconstant not available in test.support in 3.8.
I'm using the original issue here as this change fixes the original testsuite for the CVE in TLS.
An alternative for having the constant in test_ssl is to backport this commit from 3.9: 24c6258 But it touches a lot of files and I think that might be too much for 3.8.
Cc the authors of the original fix: @ambv and @gpshead