Skip to content

[3.12] gh-108303: Move all inspect test files to test_inspect/ (GH-109607)#110732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 2 commits into from
Oct 13, 2023
Merged

[3.12] gh-108303: Move all inspect test files to test_inspect/ (GH-109607) #110732

vstinner merged 2 commits into from
Oct 13, 2023

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commented Oct 11, 2023•
edited by bedevere-app bot
Loading

@sobolevn
[3.12]pythongh-108303: Move all inspect test files totest_inspect/(
f0002fe
pythonGH-109607) (cherry picked from commit 732532b) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-appbedevere-appbot mentioned this pull request Oct 11, 2023
Merged
@bedevere-appbedevere-appbot mentioned this pull request Oct 11, 2023
Closed
@sobolevn
Copy link
MemberAuthor

sobolevn commented Oct 11, 2023

@vstinner we need this PR to get backported: #109403

Otherwise, tests won't pass due to a findtests bug :(

@vstinner
Copy link
Member

vstinner commented Oct 12, 2023

@vstinner we need this PR to get backported: #109403

It became impossible to backport a single regrtest change, the 3.12 and main branches became too different. So I wrote PR #110758 to copy regrtest files from main to 3.12 branch.

@sobolevnsobolevn reopened this Oct 13, 2023
@vstinner
Copy link
Member

vstinner commented Oct 13, 2023

Can you please rebase your PR on the 3.12 branch to solve the libregrtest merge conflict?

@sobolevn
Copy link
MemberAuthor

sobolevn commented Oct 13, 2023

Should be good now! Thanks a lot for your backport PRs! They are really helpful.

@vstinnervstinner merged commit 0102faf into python:3.12Oct 13, 2023
@vstinnervstinner added the needs backport to 3.11 only security fixes label Oct 13, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Oct 13, 2023

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 13, 2023

Sorry, @sobolevn and @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0102faf0cac107fd4d0fde9902560c7cf0a3be9d 3.11

@vstinner
Copy link
Member

vstinner commented Oct 13, 2023

I was feeling lucky and tried automated backport...

@sobolevn: Do you want to try to backport to 3.11? Otherwise, I can try to backport.

@sobolevn
Copy link
MemberAuthor

sobolevn commented Oct 13, 2023

Will do tomorrow.

@ZeroIntensityZeroIntensity removed the needs backport to 3.11 only security fixes label Feb 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnerAwaiting requested review from vstinner

@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner

@encukouencukouAwaiting requested review from encukouencukou is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees

@vstinnervstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn@vstinner@miss-islington@ZeroIntensity