gh-110774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase#110776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

gvanrossum merged 6 commits into python:main from graingert:unittest-loop-factory

Oct 31, 2023

Contributor

graingert commented Oct 12, 2023•
edited by bedevere-app bot
Loading

Issue: Support setting the loop_factory in IsolatedAsyncioTestCase #110774

allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase

0ed7c50

graingert changed the title ~~allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase~~gh-10774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase

graingert changed the title ~~gh-10774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase~~gh-110774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase

bedevere-appbot mentioned this pull request

Support setting the loop_factory in IsolatedAsyncioTestCase #110774

Closed

graingert commented

View reviewed changes

Doc/library/unittest.rst Outdated Show resolvedHide resolved

graingert commented

View reviewed changes

Doc/library/unittest.rstShow resolvedHide resolved

graingert commented

View reviewed changes

Doc/library/unittest.rstShow resolvedHide resolved

graingert commented

View reviewed changes

Doc/library/unittest.rst Outdated Show resolvedHide resolved

graingert commented

View reviewed changes

Lib/test/test_unittest/test_async_case.py Outdated Show resolvedHide resolved

graingertand others added 3 commits

October 12, 2023 16:20

test IsolatedAsyncioTestCase.loop_factory

216dc96

document loop_factory attribute

a05085f

📜🤖 Added by blurb_it.

0fbb894

graingert force-pushed the unittest-loop-factory branch from 47669b3 to 0fbb894Compare

October 12, 2023 15:20

graingert marked this pull request as ready for review

October 12, 2023 15:32

bedevere-appbot added the awaiting review label

Merge branch 'main' into unittest-loop-factory

63b940c

willingc approved these changes

View reviewed changes

Contributor

willingc left a comment

Thanks @graingert. This looks good to me.

bedevere-appbot added awaiting merge and removed awaiting review labels

Merge branch 'main' into unittest-loop-factory

335e26d

gvanrossum approved these changes

View reviewed changes

Member

gvanrossum left a comment

Yup, thanks!

gvanrossum merged commit 7705306 into python:main

bedevere-appbot removed the awaiting merge label

graingert deleted the unittest-loop-factory branch

October 31, 2023 22:32

FullteaR pushed a commit to FullteaR/cpython that referenced this pull request

pythongh-110774: allow setting the Runner(loop_factory=...) from Isol…

3512380

…atedAsyncioTestCase (python#110776) Co-authored-by: Łukasz Langa <lukasz@langa.pl> Co-authored-by: Carol Willing <carolcode@willingconsulting.com>

aisk pushed a commit to aisk/cpython that referenced this pull request

pythongh-110774: allow setting the Runner(loop_factory=...) from Isol…

73dc956

…atedAsyncioTestCase (python#110776) Co-authored-by: Łukasz Langa <lukasz@langa.pl> Co-authored-by: Carol Willing <carolcode@willingconsulting.com>

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

pythongh-110774: allow setting the Runner(loop_factory=...) from Isol…

47d7b80

…atedAsyncioTestCase (python#110776) Co-authored-by: Łukasz Langa <lukasz@langa.pl> Co-authored-by: Carol Willing <carolcode@willingconsulting.com>

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment